From owner-freebsd-ports@FreeBSD.ORG Thu May 8 08:20:21 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0310137B413 for ; Thu, 8 May 2003 08:20:21 -0700 (PDT) Received: from harrier.mail.pas.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5679E43FCB for ; Thu, 8 May 2003 08:20:06 -0700 (PDT) (envelope-from welchsm@earthlink.net) Received: from louie.psp.pas.earthlink.net ([207.217.78.221]) by harrier.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 19DnBk-0000mU-00; Thu, 08 May 2003 08:20:04 -0700 Received: from [207.217.78.15] by EarthlinkWAM via HTTP; Thu May 08 08:20:04 PDT 2003 Message-ID: <8349049.1052407204827.JavaMail.nobody@louie.psp.pas.earthlink.net> Date: Thu, 8 May 2003 08:20:01 -0500 (GMT) From: Sean Welch To: freebsd-ports@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: Earthlink Web Access Mail version 3.0 Subject: snes9x still broken (for 4.7/4.8) -- Patch included X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Sean_Welch@alum.wofford.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2003 15:20:21 -0000 Looks as though the port is still broken: In file included from unix/unix.cpp:44: /usr/include/stdlib.h:111: warning: ANSI C++ does not support `long long' /usr/include/stdlib.h:117: warning: ANSI C++ does not support `long long' unix/unix.cpp: In function `void S9xParseArg(char **, int &, int)': unix/unix.cpp:299: warning: comparison between signed and unsigned unix/unix.cpp:307: warning: comparison between signed and unsigned unix/unix.cpp: In function `int InitJoystickFd(int, char *)': unix/unix.cpp:797: argument passing to `hid_kind' from `int *' unix/unix.cpp:781: warning: `int reportlen' might be used uninitialized in this function unix/unix.cpp: In function `void InitJoysticks()': unix/unix.cpp:876: warning: comparison between signed and unsigned unix/unix.cpp: At top level: unix/unix.cpp:1382: warning: `long int power(int, int)' defined but not used gmake: *** [unix/unix.o] Error 1 *** Error code 2 Stop in /usr/ports/emulators/snes9x. I suggest the folowing patch (tested on 4.8-RELEASE: --- patch-af.orig Thu May 8 09:33:20 2003 +++ patch-af Thu May 8 10:06:05 2003 @@ -272,7 +272,7 @@ void InitJoysticks () { #ifdef JSIOCGVERSION -@@ -730,6 +759,193 @@ +@@ -730,6 +759,189 @@ } #endif } @@ -304,15 +304,11 @@ + return (-1); + } + report_id = 0; -+#if __FreeBSD__ >= 5 -+#if __FreeBSD_version < 500111 ++#if (__FreeBSD__ >= 5) && (__FreeBSD_version < 500111) + reportlen = hid_report_size(rd, report_id, hid_input); +#else + reportlen = hid_report_size(rd, hid_input, report_id); +#endif -+#else -+ reportlen = hid_report_size(rd, hid_input, &report_id); -+#endif + my_info->buf = (char *)malloc(reportlen); + if (my_info->buf == NULL) + err(1, "malloc"); @@ -466,7 +462,7 @@ #endif // defined (JOYSTICK_SUPPORT) const char *GetHomeDirectory () -@@ -1422,7 +1638,7 @@ +@@ -1422,7 +1634,7 @@ } #endif @@ -475,7 +471,7 @@ static int Rates[8] = { 0, 8192, 11025, 16500, 22050, 29300, 36600, 44000 -@@ -1541,7 +1757,7 @@ +@@ -1541,7 +1753,7 @@ } #endif @@ -484,7 +480,7 @@ void S9xUnixProcessSound (void) { } -@@ -1640,7 +1856,7 @@ +@@ -1640,7 +1852,7 @@ void *S9xProcessSound (void *) {