From owner-svn-src-head@freebsd.org Thu Sep 20 19:06:21 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB4F210A63DA; Thu, 20 Sep 2018 19:06:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F79C7A936; Thu, 20 Sep 2018 19:06:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl1-x634.google.com with SMTP id s17-v6so4776743plp.7; Thu, 20 Sep 2018 12:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d3OJCJ9+4YU3/Wu7CIxbEGw5avnahHKETHigXolTnQI=; b=aGvpcJlMTNzvFCP//MBsaQul3cse8oO2axfBR3o6BCBk/n5ph7yoq/uI5wjq+zQn8H HVH6W7xY1RPabNDz8W92Qk5FJf3PvyQbN78KwbK8kggdzWhiJVN36NW+DIrfvQSjBhNn saPCDXHIjnEUamLDPfyxFNFviNOn3YiVyhyDahNvdv8KKmVMnpDLekg/3+GEUpIDgtvf haP/7RWe5a6rPcFHL59lkq23UoO4dG0FIQFi/7gngrlkLBrdNqYNq00a1W2ofBtVby6b CdRBioH/lyFYnYhKQOQr56hdBtxYTdSyvs3szO7u+YGl0qpdm+Mcjh7mec1cCHWgP+pX z9Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=d3OJCJ9+4YU3/Wu7CIxbEGw5avnahHKETHigXolTnQI=; b=KdXZsSwueUQrG6QVfXoA4NvWKwOtv1PirolfrEk6WbYytoJKyR3yl5JdZj4Ax1tPga nUWp/UwMHgiIZgqSCpF55K4sPu3oed5sQbnK2RO1qcOTj1sPgFyO87SePifb/UEH6TpI aCLD019LzyGtOBbsOGTrrS0BzyHl7XSUpwzLtG/A/9Vzfnkh1n5FgeoY7km3SbCyrmNO s+HyUk4uplSEzB+vubZ489/iHswQiT4Y5zbVyxJ3y4DwJTCl4S0NEL8jQfdjwfT1MnhL /917chilSzderf34RrM7vBmvQWefGqbOy1gPTsY73ARIHPskcFidfEmsYXF7JOYoeSHu LABg== X-Gm-Message-State: APzg51AQB9UzJIRuw3N/4iVl5f6QERHmQHgTqtsof378fnOwuN5xnJb3 maf0McaN4nkkR+PyWJO+iWTLLMiO X-Google-Smtp-Source: ANB0VdYqLKegn5V0R6fYn5NGcG02EVAk6kRiJ50kJD2QodvnZNrtWgdpoI92SU0PJ//0MQgK4EPS5A== X-Received: by 2002:a17:902:6b89:: with SMTP id p9-v6mr40387592plk.272.1537470379163; Thu, 20 Sep 2018 12:06:19 -0700 (PDT) Received: from raichu (toroon0560w-lp130-01-174-88-78-8.dsl.bell.ca. [174.88.78.8]) by smtp.gmail.com with ESMTPSA id b126-v6sm40392394pga.49.2018.09.20.12.06.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Sep 2018 12:06:17 -0700 (PDT) Sender: Mark Johnston Date: Thu, 20 Sep 2018 15:06:14 -0400 From: Mark Johnston To: John Baldwin Cc: Matt Macy , jmd@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src Message-ID: <20180920190614.GI99168@raichu> References: <201807150023.w6F0NBx1065422@repo.freebsd.org> <20180920155402.GF99168@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 19:06:22 -0000 On Thu, Sep 20, 2018 at 09:39:24AM -0700, John Baldwin wrote: > On 9/20/18 8:54 AM, Mark Johnston wrote: > > On Sun, Jul 15, 2018 at 12:23:11AM +0000, Matt Macy wrote: > >> Author: mmacy > >> Date: Sun Jul 15 00:23:10 2018 > >> New Revision: 336299 > >> URL: https://svnweb.freebsd.org/changeset/base/336299 > >> > >> Log: > >> msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd > >> > >> This corresponds to the latest status (hasn't changed in 9+ > >> years) from openbsd of ld80/ld128 powl, and source cpowf, cpow, > >> cpowl (the complex power functions for float complex, double > >> complex, and long double complex) which are required for C99 > >> compliance and were missing from FreeBSD. Also required for > >> some numerical codes using complex numbered Hamiltonians. > >> > >> Thanks to jhb for tracking down the issue with making > >> weak_reference compile on powerpc. > >> > >> When asked to review, bde said "I don't like it" - but > >> provided no actionable feedback or superior implementations. > >> > >> Discussed with: jhb > >> Submitted by: jmd > >> Differential Revision: https://reviews.freebsd.org/D15919 > > > > This seems to have broken the gcc build: > > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/ > > > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant exceeds range of 'long double' [-Werror=overflow] > > if( y >= LDBL_MAX ) > > ^~ > > Which architecture? i386 doesn't get build with i386-xtoolchain-gcc pending > some patches I haven't yet posted for review related to the weirdness we do > with floating point on i386. This is the -m32 build on amd64. I haven't tested it myself, but Mark Millard noted that the issue might be fixed by a gcc update.