From owner-svn-src-head@FreeBSD.ORG Tue Jun 7 18:02:13 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22F6F1065679; Tue, 7 Jun 2011 18:02:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id ECD8D8FC13; Tue, 7 Jun 2011 18:02:12 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9946A46B46; Tue, 7 Jun 2011 14:02:12 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 14E138A01F; Tue, 7 Jun 2011 14:02:12 -0400 (EDT) From: John Baldwin To: "Jung-uk Kim" Date: Tue, 7 Jun 2011 14:02:11 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201106062303.p56N3cjs053024@svn.freebsd.org> <201106070952.49563.jhb@freebsd.org> <201106071139.41955.jkim@FreeBSD.org> In-Reply-To: <201106071139.41955.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106071402.11620.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 07 Jun 2011 14:02:12 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r222795 - head/sys/dev/atkbdc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2011 18:02:13 -0000 On Tuesday, June 07, 2011 11:39:26 am Jung-uk Kim wrote: > On Tuesday 07 June 2011 09:52 am, John Baldwin wrote: > The whole point of this commit is to blacklist *recent* BIOS (or CSM) > from probing keyboard typematic information, more specifically, > recent Intel chipset platforms. They don't support many INT 15h/16h > functions but only cause trouble at best. OTOH, I haven't seen such > problems with AMD chipset systems and they all seem to have > traditional entry points at the interrupt vector table, for example. Err, but you didn't blacklist recent BIOS. You blacklist _all_ BIOS that use entry points other than the ones from the UEFI spec, including BIOSes that don't claim to support UEFI and the BIOS from the two systems I quoted. > > You might as well just turn the check off on all machines at this > > point rather than using completely arbitrary tests that are only > > valid on a small fraction of the x86 universe. > > I don't think it is "completely" arbitrary. If it doesn't have the > traditional entry points, it is very unlikely to support keyboard > typematic in the first place. Please let me know if you have any > counter example. Umm, I just gave you two examples. UEFI is not a standard appropriate to the vast majority of x86 BIOS implementations. It is far, far too narrow. Put another way, we should assume that all non-recent BIOSes do not conform to UEFI (since many older systems pre-date the UEFI spec for one) and that they have all been effectively blacklisted now. Given that, you've now restricted this functionality to only a subset of recent BIOSes and have blacklisted the rest of the known universe. However, the simplest fix is probably to just remove this entirely as I doubt anyone really depends on the BIOS settings for these anyway. -- John Baldwin