From owner-freebsd-bugs@freebsd.org Fri Apr 9 17:24:03 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 72F5E5BEC06 for ; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FH4jv1GtWz4vgT for ; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2BC725BEC05; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B8625BEA9E for ; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FH4jv0gsbz4vZd for ; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0A5282208C for ; Fri, 9 Apr 2021 17:24:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 139HO2RT070615 for ; Fri, 9 Apr 2021 17:24:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 139HO2IK070614 for bugs@FreeBSD.org; Fri, 9 Apr 2021 17:24:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 254924] stp does not validate timer values in config BPDU Date: Fri, 09 Apr 2021 17:24:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jcaplan@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 17:24:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254924 Bug ID: 254924 Summary: stp does not validate timer values in config BPDU Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jcaplan@blackberry.com Created attachment 223952 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D223952&action= =3Dedit proposed patch Overview -------- IEEE Std 802.1D-2004 Section 17.14 defines permitted ranges for timers. Incoming BPDU messages should be checked against the permitted ranges. The = rest of 17.14 appears to be enforced already. Steps to Reproduce ------------------ Send an invalid config with scapy (maxage > 40, fwddelay > 30): >>stp =3D Ether(src=3D"00:0c:29:0b:91:0a",dst=3D"01:80:C2:00:00:00")/LLC()/= STP(proto=3D0,rootid=3D32768,rootmac=3D"00:0c:29:01:01:01",bridgeid=3D32768= ,bridgemac=3D"00:0c:29:01:01:01",portid=3D0x8007,maxage=3D50,hellotime=3D2,= fwddelay=3D40) >>sendp(stp,inter=3D1./1,iface=3D"em1",loop=3D1) Actual Results -------------- tcpdump shows configuration is accepted and forwarded by other ports: tcpdump: listening on em1, link-type EN10MB (Ethernet), capture size 262144 bytes 17:35:34.930786 STP 802.1d, Config, Flags [none], bridge-id 8000.00:0c:29:c8:34:91.8002, length 43 message-age 2.00s, max-age 50.00s, hello-time 2.00s, forwarding-delay 40.00s Expected Results ---------------- The invalid config is discarded --=20 You are receiving this mail because: You are the assignee for the bug.=