From owner-svn-src-stable@freebsd.org Wed Mar 15 14:31:02 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 037DCD0E1D6; Wed, 15 Mar 2017 14:31:02 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B9152774; Wed, 15 Mar 2017 14:31:01 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1co9wz-000IuW-7K; Wed, 15 Mar 2017 17:30:53 +0300 Date: Wed, 15 Mar 2017 17:30:53 +0300 From: Slawa Olhovchenkov To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r313450 - in stable/11: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20170315143053.GW15630@zxy.spb.ru> References: <201702081832.v18IWZlC001828@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702081832.v18IWZlC001828@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 14:31:02 -0000 On Wed, Feb 08, 2017 at 06:32:35PM +0000, John Baldwin wrote: > Author: jhb > Date: Wed Feb 8 18:32:35 2017 > New Revision: 313450 > URL: https://svnweb.freebsd.org/changeset/base/313450 > > Log: > MFC 310638: > Rename the 'flags' argument to getfsstat() to 'mode' and validate it. > > This argument is not a bitmask of flags, but only accepts a single value. > Fail with EINVAL if an invalid value is passed to 'flag'. Rename the > 'flags' argument to getmntinfo(3) to 'mode' as well to match. > > This is a followup to r308088. > kern_getfsstat(struct thread *td, struct statfs **buf, size_t bufsize, > - size_t *countp, enum uio_seg bufseg, int flags) > + size_t *countp, enum uio_seg bufseg, int mode) > { > struct mount *mp, *nmp; > struct statfs *sfsp, *sp, *sptmp, *tofree; > size_t count, maxcount; > int error; > > + switch (mode) { > + case MNT_WAIT: > + case MNT_NOWAIT: > + break; > + default: > + return (EINVAL); > + } > restart: This is break net-snmp UCD-SNMP-MIB::dskTable oid: 82434 snmpd CALL getfsstat(0,0,) 82434 snmpd RET getfsstat -1 errno 22 Invalid argument 82434 snmpd CALL getfsstat(0,0xfffffffffffffe28,MNT_NOWAIT) 82434 snmpd RET getfsstat -1 errno 22 Invalid argument 82434 snmpd CALL write(0x9,0x800f162ea,0x1)