Date: Sun, 15 Feb 2015 01:10:50 -0500 From: Pedro Giffuni <pfg@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r278790 - head/sys/fs/ext2fs Message-ID: <8D00DA70-E1B2-4B5F-996E-676087B27761@freebsd.org> In-Reply-To: <201502150112.t1F1CFHj097770@svn.freebsd.org> References: <201502150112.t1F1CFHj097770@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Il giorno 14/feb/2015, alle ore 20:12, Pedro F. Giffuni = <pfg@freebsd.org> ha scritto: >=20 > Author: pfg > Date: Sun Feb 15 01:12:15 2015 > New Revision: 278790 > URL: https://svnweb.freebsd.org/changeset/base/278790 >=20 > Log: > Initialize the allocation of variables related to the ext2 allocator. >=20 > The e2fs_gd struct was not being initialized and garbage was > being used for hinting the ext2 allocator variant. > Use malloc to clear the values and also initialize e2fs_contigdirs > during allocation to keep consistency. >=20 > While here clean up small style issues. >=20 > Reported by: Clang static analyser > MFC after: 1 week >=20 > Modified: > head/sys/fs/ext2fs/ext2_vfsops.c >=20 Actually .. it=E2=80=99s a false positive but there is a memory leak = there so taking a fresh look at the code was good. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8D00DA70-E1B2-4B5F-996E-676087B27761>