From owner-svn-src-all@FreeBSD.ORG  Sun Feb 15 10:51:58 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4203CBFC
 for <svn-src-all@freebsd.org>; Sun, 15 Feb 2015 10:51:58 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
 by mx1.freebsd.org (Postfix) with SMTP id E1ECB999
 for <svn-src-all@freebsd.org>; Sun, 15 Feb 2015 10:51:57 +0000 (UTC)
Received: (qmail 93312 invoked by uid 99); 15 Feb 2015 06:10:53 -0000
Received: from mail-relay.apache.org (HELO mail-relay.apache.org)
 (140.211.11.15)
 by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Feb 2015 06:10:53 +0000
Received: from [192.168.0.103] (unknown [190.157.136.22])
 by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with
 ESMTPSA id 50C3D1A0031; Sun, 15 Feb 2015 06:10:52 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\))
Subject: Re: svn commit: r278790 - head/sys/fs/ext2fs
From: Pedro Giffuni <pfg@freebsd.org>
In-Reply-To: <201502150112.t1F1CFHj097770@svn.freebsd.org>
Date: Sun, 15 Feb 2015 01:10:50 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <8D00DA70-E1B2-4B5F-996E-676087B27761@freebsd.org>
References: <201502150112.t1F1CFHj097770@svn.freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
X-Mailer: Apple Mail (2.2070.6)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Feb 2015 10:51:58 -0000


> Il giorno 14/feb/2015, alle ore 20:12, Pedro F. Giffuni =
<pfg@freebsd.org> ha scritto:
>=20
> Author: pfg
> Date: Sun Feb 15 01:12:15 2015
> New Revision: 278790
> URL: https://svnweb.freebsd.org/changeset/base/278790
>=20
> Log:
>  Initialize the allocation of variables related to the ext2 allocator.
>=20
>  The e2fs_gd struct was not being initialized and garbage was
>  being used for hinting the ext2 allocator variant.
>  Use malloc to clear the values and also initialize e2fs_contigdirs
>  during allocation to keep consistency.
>=20
>  While here clean up small style issues.
>=20
>  Reported by:	Clang static analyser
>  MFC after:	1 week
>=20
> Modified:
>  head/sys/fs/ext2fs/ext2_vfsops.c
>=20

Actually .. it=E2=80=99s a false positive but there is a memory leak =
there so
taking a fresh look at the code was good.

Pedro.