From owner-svn-ports-all@freebsd.org Thu Jun 18 17:06:47 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9200F35553F; Thu, 18 Jun 2020 17:06:47 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from forward1-smtp.messagingengine.com (forward1-smtp.messagingengine.com [66.111.4.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49npJ71TCDz3Sw5; Thu, 18 Jun 2020 17:06:46 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id 730DE1940BD5; Thu, 18 Jun 2020 13:06:46 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute2.internal (MEProxy); Thu, 18 Jun 2020 13:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=SBYL8u e6TZqXbEGwA/zQMhebVa4NAOtDgHkZxbEPqNI=; b=Rr1b+YxWxoJ4VHkWyILcN2 5dmoqZEWZWBP8iUFsQ4TucvMco2dXVJEjJsUfkhjIfmIDfXresPLzH9hLsxOGilQ ZzceViV9NNHDgO4BzGqTJJ0PNS3qVWG3mjwQRD+GOaq6jh6UTqftoGnBw1SbqN/M U8Nqh5uXUgRy8ZNXf41qKqtH1sz5v+YgTPXuOntVnPo5RumMHrIkR8IS2+Yl/fpE aqW7LiSJT8VGggJ/pinKB+1c8aUYZ+cRQgaKH35ukwpNGkY60VXmUXACGSEYTy2d V4L140dmuqriwwxNewiIZ9/FE+kdFlAgQjay49A5Wy0giYIk35OPFMF9GbTCMFhA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfvfho sghirghsucfmohhrthhkrghmphdfuceothhosghikheshfhrvggvuefuffdrohhrgheqne cuggftrfgrthhtvghrnhepfeetgeevgefftedvueffveefudeugfetueeukeelhfeiiedt teeftedugfefveegnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhosghikheshfhrvggv uefuffdrohhrgh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 02843C200A5; Thu, 18 Jun 2020 13:06:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-536-ga595028-fm-20200618.001-ga5950281 Mime-Version: 1.0 Message-Id: In-Reply-To: <202006171702.05HH2ZVH019476@repo.freebsd.org> References: <202006171702.05HH2ZVH019476@repo.freebsd.org> Date: Thu, 18 Jun 2020 17:04:21 +0000 From: "Tobias Kortkamp" To: "Mark Linimon" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r539431 - head/lang/smlnj Content-Type: text/plain X-Rspamd-Queue-Id: 49npJ71TCDz3Sw5 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 17:06:47 -0000 On Wed, Jun 17, 2020, at 17:02, Mark Linimon wrote: > Author: linimon > Date: Wed Jun 17 17:02:35 2020 > New Revision: 539431 > URL: https://svnweb.freebsd.org/changeset/ports/539431 > > Log: > Fix INDEX build on !x86 architectures. > > Approved by: portmgr (tier-2 blanket) > > Modified: > head/lang/smlnj/Makefile > > Modified: head/lang/smlnj/Makefile > ============================================================================== > --- head/lang/smlnj/Makefile Wed Jun 17 16:41:24 2020 (r539430) > +++ head/lang/smlnj/Makefile Wed Jun 17 17:02:35 2020 (r539431) > @@ -79,7 +79,7 @@ MLSRCS+= ${MLROOT}/${srcdir} > MLTARGETS= heap2asm > MLEXE= asdlgen heap2exec ml-antlr ml-build ml-burg ml-lex \ > ml-makedepend ml-ulex ml-yacc sml > -.if ${MLSIZE} == 32 > +.if defined(${MLSIZE}) && ${MLSIZE} == 32 > MLEXE+= ml-nlffigen > .endif Now the condition looks broken to me. defined(${MLSIZE}) is only true if MLSIZE's value happens to be a defined variable name. Instead this should be .if defined(MLSIZE) && ${MLSIZE} == 32