From owner-freebsd-ppc@FreeBSD.ORG Wed Apr 9 00:32:18 2008 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDCF2106564A for ; Wed, 9 Apr 2008 00:32:18 +0000 (UTC) (envelope-from nathanw@uchicago.edu) Received: from agogare.doit.wisc.edu (agogare.doit.wisc.edu [144.92.197.211]) by mx1.freebsd.org (Postfix) with ESMTP id AE2D68FC19 for ; Wed, 9 Apr 2008 00:32:18 +0000 (UTC) (envelope-from nathanw@uchicago.edu) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=KOI8-R; format=flowed Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 6.3-5.02 (built Oct 12 2007; 32bit)) id <0JZ10060485U1G00@smtpauth2.wiscmail.wisc.edu>; Tue, 08 Apr 2008 19:32:18 -0500 (CDT) Received: from trantor.tachypleus.net ([76.201.152.232]) by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 6.3-5.02 (built Oct 12 2007; 32bit)) with ESMTPSA id <0JZ1004SZ85R4Q00@smtpauth2.wiscmail.wisc.edu>; Tue, 08 Apr 2008 19:32:16 -0500 (CDT) Date: Tue, 08 Apr 2008 19:36:43 -0500 From: Nathan Whitehorn In-reply-to: <20080404061224.GB11845@FreeBSD.org> To: Alexey Dokuchaev Message-id: <47FC0F9B.6070902@uchicago.edu> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.201.152.232 X-Spam-PmxInfo: Server=avs-7, Version=5.4.1.325704, Antispam-Engine: 2.6.0.325393, Antispam-Data: 2008.4.8.171613, SenderIP=76.201.152.232 References: <47F3D2BC.7060001@uchicago.edu> <47F422A0.9080907@uchicago.edu> <47F4E007.90802@uchicago.edu> <3B02E59E-5399-40B6-9747-2F49200FD708@mac.com> <47F59C13.9030705@uchicago.edu> <20080404061224.GB11845@FreeBSD.org> User-Agent: Thunderbird 2.0.0.12 (X11/20080322) Cc: freebsd-ppc@freebsd.org Subject: Re: BMAC Ethernet Driver X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2008 00:32:18 -0000 Alexey Dokuchaev wrote: > On Thu, Apr 03, 2008 at 10:10:11PM -0500, Nathan Whitehorn wrote: >> --- macio.c 2007-12-20 18:23:22.000000000 -0600 >> +++ macio.c.multi 2008-04-03 20:00:23.562978813 -0500 >> @@ -179,27 +179,40 @@ >> static void >> macio_add_intr(phandle_t devnode, struct macio_devinfo *dinfo) >> { >> - int intr; >> + int *intr; >> + int i, nintr; >> + phandle_t iparent; >> + int icells; > > From examples I see in man style(9), type and varname for local vars are > seperated by space, not a tab. Hmm. I was mostly just trying to match the style in the rest of macio.c. Is it a better idea in this circumstance to match style(9) or the existing code? -Nathan