From owner-svn-src-all@FreeBSD.ORG Mon Jan 6 14:34:15 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 022DFBA5; Mon, 6 Jan 2014 14:34:15 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C3B361661; Mon, 6 Jan 2014 14:34:14 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1W0BFt-0003gK-E1; Mon, 06 Jan 2014 14:34:13 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s06EYApF027596; Mon, 6 Jan 2014 07:34:10 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+ISPuZDe8i+pxAzkhhHfmE Subject: Re: svn commit: r260161 - in head/sys/arm: arm include From: Ian Lepore To: Zbigniew Bodek In-Reply-To: References: <201401012003.s01K3ngn009757@svn.freebsd.org> <1388976912.1158.331.camel@revolution.hippie.lan> <52CA3C07.9030002@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" Date: Mon, 06 Jan 2014 07:34:10 -0700 Message-ID: <1389018850.1158.333.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Andreas Tobler X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 14:34:15 -0000 On Mon, 2014-01-06 at 13:07 +0100, Zbigniew Bodek wrote: > 2014/1/6 Andreas Tobler : > > On 06.01.14 03:55, Ian Lepore wrote: > >> On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote: > >>> Author: zbb > >>> Date: Wed Jan 1 20:03:48 2014 > >>> New Revision: 260161 > >>> URL: http://svnweb.freebsd.org/changeset/base/260161 > >>> > >>> Log: > >>> Add polarity and level support to ARM GIC > >>> > >>> Add suport for setting triggering level and polarity in GIC. > >>> New function pointer was added to nexus which corresponds > >>> to the function which sets level/sense in the hardware (GIC). > >>> > >>> Submitted by: Wojciech Macek > >>> Obtained from: Semihalf > >>> > >>> Modified: > >>> head/sys/arm/arm/gic.c > >>> head/sys/arm/arm/intr.c > >>> head/sys/arm/arm/nexus.c > >>> head/sys/arm/include/intr.h > >>> > >> [...] > >>> Modified: head/sys/arm/include/intr.h > >>> ============================================================================== > >>> --- head/sys/arm/include/intr.h Wed Jan 1 19:38:15 2014 (r260160) > >>> +++ head/sys/arm/include/intr.h Wed Jan 1 20:03:48 2014 (r260161) > >>> @@ -68,6 +68,7 @@ > >>> #endif > >>> > >>> #include > >>> +#include > >>> > >>> int arm_get_next_irq(int); > >>> void arm_mask_irq(uintptr_t); > >>> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *, > >>> void *, int, int, void **); > >>> int arm_remove_irqhandler(int, void *); > >>> extern void (*arm_post_filter)(void *); > >>> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig, > >>> + enum intr_polarity pol); > >>> > >>> void gic_init_secondary(void); > >>> > >> > >> It turns out that the new #include in this change is causing the current > >> arm tinderbox failures. Enums can't have forward decls anymore, so the > >> fix for this may not be easy. > > > > I posted my try to fix this here: > > > > http://lists.freebsd.org/pipermail/freebsd-current/2014-January/047694.html > > > > Rebuilt 260333 successfully with it. > > > > Andreas > > > > Hello. > > Thank you very much. Can this be committed or are there any objections? > > Best regards > zbb It looks good to me. It's odd that the tinderbox has been failing for several days on this, but I've been doing universe-kernel builds all weekend without running into it. I wonder what's different between tinderbox and universe in this regard? -- Ian