From owner-freebsd-doc Sat Mar 22 17:14:21 2003 Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26C8037B408; Sat, 22 Mar 2003 17:14:12 -0800 (PST) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0ABE144146; Sat, 22 Mar 2003 17:05:09 -0800 (PST) (envelope-from keramida@FreeBSD.org) Received: from gothmog.gr (patr530-a179.otenet.gr [212.205.215.179]) by mailsrv.otenet.gr (8.12.8/8.12.8) with ESMTP id h2N155h1014639; Sun, 23 Mar 2003 03:05:06 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.8/8.12.8) with ESMTP id h2N0XJGg071471; Sun, 23 Mar 2003 02:33:19 +0200 (EET) (envelope-from keramida@FreeBSD.org) Received: (from giorgos@localhost) by gothmog.gr (8.12.8/8.12.8/Submit) id h2N0XJFA071470; Sun, 23 Mar 2003 02:33:19 +0200 (EET) (envelope-from keramida@FreeBSD.org) Date: Sun, 23 Mar 2003 02:33:19 +0200 From: Giorgos Keramidas To: "Bruce A. Mah" Cc: freebsd-doc@FreeBSD.org, re@FreeBSD.org Subject: Re: ulink elements and URL duplication in the docs Message-ID: <20030323003319.GA71388@gothmog.gr> References: <20030322215305.GB57850@gothmog.gr> <20030322224641.GA71175@intruder.bmah.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <20030322224641.GA71175@intruder.bmah.org> X-RAVMilter-Version: 8.4.2(snapshot 20021217) (terpsi) Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 2003-03-22 14:46, "Bruce A. Mah" wrote: >If memory serves me right, Giorgos Keramidas wrote: >> >> http://www.FreeBSD.org/~keramida/diff/_03.ulink.patch >> Do you all think it's ok to make the changes of that diff? > > Hmmm. I only perused the diff, but this looks pretty good to me. > Could you do a quick check to see if our print stylesheets generate > sane output as well? (I think they do, but just to be sure...) It should be exactly the same. This is the reason from freebsd.dsl. (element ulink (make sequence (if (node-list-empty? (children (current-node))) (literal (fix-url (attribute-string (normalize "url")))) (make sequence ...)))) If there is no content in the URL attribute is used. A quick look at a few of the affected files built with and without the change seems to look alright here. I only looked HTML output, so if someone wants to test this with PDF or other formats, please feel free. I'll wait until after 4.8-RELEASE anyway, so we have time. >> If yes, is it ok to do it now, or should I just wait for a date after >> 4.8-RELEASE to avoid making large changes at this point in time? > > I tagged the doc/ tree a couple days ago...I think at this point it'd > probably be better to wait. It'll probably just be a few more days. Ok. I can do it later. This is mainly why I Cc:'ed re :-) --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+fQDP1g+UGjGGA7YRAn4BAJ9hohl+ZwuvCBCfnKn0MaNNPqfDZwCeJm/B 1aMlgGkQjsEtflZSaIp/94s= =nlO9 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message