From owner-cvs-all Mon Sep 9 14: 0:52 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DB0C37B401 for ; Mon, 9 Sep 2002 14:00:47 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3847143E4A for ; Mon, 9 Sep 2002 14:00:46 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13618 invoked from network); 9 Sep 2002 21:00:43 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 9 Sep 2002 21:00:43 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g89L0iBv028675; Mon, 9 Sep 2002 17:00:44 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200209092029.g89KTtoM045360@intruder.bmah.org> Date: Mon, 09 Sep 2002 17:00:45 -0400 (EDT) From: John Baldwin To: "Bruce A. Mah" Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 09-Sep-2002 Bruce A. Mah wrote: > If memory serves me right, John Baldwin wrote: > >> On 09-Sep-2002 Bruce A. Mah wrote: >> > bmah 2002/09/09 12:44:17 PDT >> > >> > Modified files: >> > usr.sbin/pkg_install/add main.c >> > Log: >> > Make pkg_install go to the right place for 4.6-RELEASE and 4.6.2-RELEASE >> > packages. >> > >> > Pointed out by: obrien >> > Reviewed by: jhb >> >> Actually, my bad, I think the upper limit for 4.6.2 should likely be 460099, >> not 460100. Other than that, thanks! > > Urk. I just looked over the commit logs for param.h, and you're right, > we should have used 460099 there. > > This would only cause a problem if someone had a pkg_add binary from a > recent 4-STABLE or 4.6-STABLE (i.e. after this commit) but they were > running it on an old 4-STABLE machine that had a __FreeBSD_version of > 460100. Also, 460100 was only in use for 10 hours (plus 40 minutes, and > 17 seconds). I guess I ought to go fix this up though, what do you > think? I would go ahead and just fix it mostly so that in the future we have a more correct example to copy and paste from so we don't propagate the error further in, say, 4.7. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message