From owner-cvs-src@FreeBSD.ORG Thu Nov 16 16:09:35 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F28F516A589; Thu, 16 Nov 2006 16:09:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABF6943D6D; Thu, 16 Nov 2006 16:09:33 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kAGG9ODa041483; Thu, 16 Nov 2006 11:09:25 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: mjacob@freebsd.org Date: Thu, 16 Nov 2006 11:09:21 -0500 User-Agent: KMail/1.9.1 References: <200611152018.kAFKI9A3061678@repoman.freebsd.org> <20061115134949.T1700@ns1.feral.com> <20061115192354.D7197@ns1.feral.com> In-Reply-To: <20061115192354.D7197@ns1.feral.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611161109.21895.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 16 Nov 2006 11:09:25 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2200/Thu Nov 16 09:10:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 16:09:35 -0000 On Wednesday 15 November 2006 22:30, mjacob@freebsd.org wrote: > > MSI/MSI-X seemed work with MPT for SAS, 4Gb FibreChannel on one system > (SuperMicro Xeon) and 2Gb FibreChannel on another (4xdual core Opteron), > but failed for onboard MPT on that system (dual core Opteron) > > mpt3: request 0xffffffff80e75050:96 timed out for ccb 0xffffff01433ec400 > (req->ccb 0xffffff01433ec400) > mpt3: completing timedout/aborted req 0xffffffff80e75050:96 > mpt3: Timedout requests already complete. Interrupts may not be > functioning. > mpt2: request 0xffffffff80e67050:96 timed out for ccb 0xffffff0141c75c00 > (req->ccb 0xffffff0141c75c00) > mpt2: completing timedout/aborted req 0xffffffff80e67050:96 > mpt2: Timedout requests already complete. Interrupts may not be > functioning. > > > MSI/MSI-X failed to work for the onboard em on the SuperMicro system. > > Given the (unselective) failure rate for me and the relatively small > sample, but with two pretty widely used system types I'd like to suggest > that you reconsider making the MSI and MSI-X being 'on' as the default. It is current, so I think having it on is ok. When I put it in 6.x it will be off by default (eventually the defualt in 6.x may change after broader testing). If you have chipsets that don't work, we can certainly blacklist those. However, we aren't likely to find them if no one tries MSI on them. Also, in your case it looks like you might have an HT bridge that needs the MSI window turned on. I haven't committed that patch as I haven't been able to get it tested yet. Please try http://www.freebsd.org/~jhb/patches/msi_ht.patch -- John Baldwin