From owner-cvs-all@FreeBSD.ORG Mon Jul 31 22:53:12 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93BC216A4E2; Mon, 31 Jul 2006 22:53:12 +0000 (UTC) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (82.193.106.18.ipnet.kiev.ua [82.193.106.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9019F43D62; Mon, 31 Jul 2006 22:53:08 +0000 (GMT) (envelope-from ru@FreeBSD.org.ua) Received: from frdp.freebsd.org.ua (localhost [127.0.0.1]) by frdp.freebsd.org.ua (8.13.6/8.13.6) with ESMTP id k6VMt1S6094019; Tue, 1 Aug 2006 01:55:01 +0300 (EEST) (envelope-from ru@FreeBSD.org.ua) Received: (from ru@localhost) by frdp.freebsd.org.ua (8.13.6/8.13.6/Submit) id k6VMt0Gs093998; Tue, 1 Aug 2006 01:55:00 +0300 (EEST) (envelope-from ru) Date: Tue, 1 Aug 2006 01:55:00 +0300 From: Ruslan Ermilov To: Yar Tikhiy Message-ID: <20060731225500.GB46645@frdp.freebsd.org.ua> References: <200607302051.k6UKpfNU011188@repoman.freebsd.org> <20060731140951.GC48538@comp.chem.msu.su> <20060731163209.GB50797@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <20060731163209.GB50797@comp.chem.msu.su> User-Agent: Mutt/1.5.12-2006-07-14 Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Marcel Moolenaar Subject: Re: cvs commit: src/usr.sbin/kldxref Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 22:53:12 -0000 --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2006 at 08:32:09PM +0400, Yar Tikhiy wrote: > On Mon, Jul 31, 2006 at 09:10:43AM -0700, Marcel Moolenaar wrote: > >=20 > > On Jul 31, 2006, at 7:09 AM, Yar Tikhiy wrote: > >=20 > > >On Sun, Jul 30, 2006 at 08:51:41PM +0000, Marcel Moolenaar wrote: > > >>marcel 2006-07-30 20:51:41 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> usr.sbin/kldxref Makefile > > >> Log: > > >> Use NO_SHARED=3DYES to force a static link. > > >> > > >> Pointed out by: ru@ > > >> > > >> Revision Changes Path > > >> 1.9 +1 -1 src/usr.sbin/kldxref/Makefile > > > > > >Perhaps it should be spelled just ``NO_SHARED=3D'' in keeping with > > >the current style? > >=20 > > I really don't know. Those NO_FOO knobs are not logical in their > > use. > >=20 > > > Unfortunately style.Makefile(5) doesn't seem > > >to list this rule... > >=20 > > Feel free to change my commit to whatever you think is right. >=20 > I was sly enough to add Ruslan to Cc in my previous mail :-) > Let's wait for his opinion on this and below. >=20 NO_SHARED is special in that it's usually set for a group of programs, e.g. src/bin/Makefile.inc, and then needs to be reset for some of them, e.g. src/bin/rmail/Makefile. > In the meanwhile I peeked in /usr/share/mk and found that the handling > of NO_* knobs is quite far from being consistent. For example: >=20 > - NO_MAN -- can be just defined ("YES" and "NO" both mean true), > handled at level (note that > is often included separately now and includes some magic); >=20 > - NO_OBJ -- can be just defined to be true, handled in , > which is included from more convenient files like ; >=20 > - NO_SHARED -- must be set to something !=3D "no" for the effect, > handled in . >=20 > I'm unsure if there is a reason behind all this diversity. >=20 NO_MAN is new style, NO_OBJ is old style and should be easily convertable, NO_SHARED is old style and not easily convertable. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFEzopEqRfpzJluFF4RAo5wAJ9ZfNm6zb1IGUEHjfCyUtPz/IFaTwCeNI+5 7puYbvte7dwlqJBrQzgpLRA= =dtF6 -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX--