From owner-freebsd-net  Wed Oct 11  0:47:46 2000
Delivered-To: freebsd-net@freebsd.org
Received: from coconut.itojun.org (coconut.itojun.org [210.160.95.97])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6E60437B503; Wed, 11 Oct 2000 00:47:43 -0700 (PDT)
Received: from kiwi.itojun.org (localhost.itojun.org [127.0.0.1])
	by coconut.itojun.org (8.9.3+3.2W/3.7W) with ESMTP id QAA23732;
	Wed, 11 Oct 2000 16:46:06 +0900 (JST)
To: Luigi Rizzo <luigi@info.iet.unipi.it>
Cc: Archie Cobbs <archie@whistle.com>, bmilekic@FreeBSD.ORG,
	freebsd-net@FreeBSD.ORG
In-reply-to: luigi's message of Wed, 11 Oct 2000 07:29:28 +0200.
      <200010110529.HAA85814@info.iet.unipi.it>
X-Template-Reply-To: itojun@itojun.org
X-Template-Return-Receipt-To: itojun@itojun.org
X-PGP-Fingerprint: F8 24 B4 2C 8C 98 57 FD  90 5F B4 60 79 54 16 E2
Subject: Re: ip_input.c patch
From: itojun@iijlab.net
Date: Wed, 11 Oct 2000 16:46:06 +0900
Message-ID: <23730.971250366@coconut.itojun.org>
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>don't think there is much need for that... ip_len and ip_off are
>mostly or probably only used in ip_input() and there you just need
>to fetch&swap a copy of the value into a local variable on entry
>and use the local variable afterwards. Even better for ip_id which
>is only used for equality comparisons...

	while i 100% agree that we should not swap bytes in ip_input,
	we need to be very sure to preserve (strange) byte ordering constraint
	in raw ip socket (IP_HDRINCL)...  so be careful.

itojun


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message