Date: Tue, 25 Oct 2016 09:43:25 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210626] archivers/libarchive: Fails to build when archivers/lzmalib is installed Message-ID: <bug-210626-13-3BAJOTCrPT@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-210626-13@https.bugs.freebsd.org/bugzilla/> References: <bug-210626-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210626 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Assignee|glewis@FreeBSD.org |freebsd-ports-bugs@FreeBSD. | |org CC| |koobs@FreeBSD.org --- Comment #7 from Kubilay Kocak <koobs@FreeBSD.org> --- Maintainer timeout (4+ months), open to take. @Walter If the current version of the patch does not fix the issue on certa= in version(s) of FreeBSD, the patch should also include a BROKEN message for OSVERSION(s) that match. Having said that, adding lzma as an unconditional dependency (as attachment 173697 does is only a workaround) I also note that there are no explicit --without flags being provided to configure for lzma by the port, but the ./configure script provides at least these options: --without-lzmadec Don't build support for lzma through lzmadec --without-lzma Don't build support for xz through lzma Further, the CMake build (which the port does not use) configuration provid= es: CMakeLists.txt:IF(ENABLE_LZMA) CMakeLists.txt: FIND_PACKAGE(LZMA) Allowing lzma to be explicitly disabled unless otherwise enabled (in the po= rt, or by an option). Note also there are lzma *specific* variables to provide include/library locations. All of the above is orthogonal to the removal of unconditional and global *FLAGS is, which should be only be used as a last resort in most port cases, *particularly* those ports that have multiple optional dependencies that all live at the same location, making accidental autodetection and linking more than common. Unfortunately global use of *FLAGS has been made way too easy = with USES=3Dlocalbase. Finally, this port overall requires a refactor and improvements to bring it into line with correct and robust ways to do things, including optional dependencies. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210626-13-3BAJOTCrPT>