From owner-freebsd-arm@FreeBSD.ORG Tue Jun 2 00:41:32 2009 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84D401065674 for ; Tue, 2 Jun 2009 00:41:32 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by mx1.freebsd.org (Postfix) with ESMTP id 3D7448FC20 for ; Tue, 2 Jun 2009 00:41:31 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by yx-out-2324.google.com with SMTP id 8so4097810yxb.13 for ; Mon, 01 Jun 2009 17:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=R9kou/JCxKMYRXJBAo1yKNcTONJDJKkSJmHmemwnYIs=; b=m6XVontYiBNJrTsdenS8YFQUjMvVYzT7xbNT1mQzgsQd82eU5TiemRF6omtRkqUT+t gYwhDUENletR7cL/ldQvWzH4+M+kIXI1Ie+LTpnd4uVDBc3jf0bs2I+7H3gZxuPma6wi 9RD4ZED6YS1lgBsp5BUWAAxxi6aTJagGiw17g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Qddk1vCQ0scB6tBk8/+uKUauRo4+ERu4X7kFhqV5sv9ZdoAcT+ps4fllHbGlZ3FzAw Dk1aqTudkd8amp6T3qQsyT3+pU7D2bp6TYsORraGGMnkVoRrePtJ2C1ZmJujhWZR1die vErBhAa2Ku2AuvrAqQ7AmatwqHRX9QG3wsk/4= MIME-Version: 1.0 Sender: mat.macy@gmail.com Received: by 10.100.209.14 with SMTP id h14mr8068604ang.139.1243901360334; Mon, 01 Jun 2009 17:09:20 -0700 (PDT) In-Reply-To: <20090601.175146.255408209.imp@bsdimp.com> References: <200906012209.n51M9gTU094161@svn.freebsd.org> <20090601.175146.255408209.imp@bsdimp.com> Date: Mon, 1 Jun 2009 17:09:20 -0700 X-Google-Sender-Auth: 4d059cce07f81d81 Message-ID: <3c1674c90906011709g757a3abds75a0cde8927bc46b@mail.gmail.com> From: Kip Macy To: "M. Warner Losh" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: arm@freebsd.org Subject: Re: svn commit: r193282 - stable/7/sys/libkern X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2009 00:41:32 -0000 No, this is a band-aid for a mistake I made in the ZFS MFC. I had hoped to avoid updating all the files., but I will do that if need be. Cheers, Kip On Mon, Jun 1, 2009 at 4:51 PM, M. Warner Losh wrote: > In message: <200906012209.n51M9gTU094161@svn.freebsd.org> > =A0 =A0 =A0 =A0 =A0 =A0Kip Macy writes: > : Author: kmacy > : Date: Mon Jun =A01 22:09:42 2009 > : New Revision: 193282 > : URL: http://svn.freebsd.org/changeset/base/193282 > : > : Log: > : =A0 memmove is defined in support.S on arm - don't compile in > : > : Modified: > : =A0 stable/7/sys/libkern/memmove.c > : > : Modified: stable/7/sys/libkern/memmove.c > : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > : --- stable/7/sys/libkern/memmove.c =A0 =A0Mon Jun =A01 22:05:08 2009 = =A0 =A0 =A0 =A0(r193281) > : +++ stable/7/sys/libkern/memmove.c =A0 =A0Mon Jun =A01 22:09:42 2009 = =A0 =A0 =A0 =A0(r193282) > : @@ -29,6 +29,7 @@ __FBSDID("$FreeBSD$"); > : > : =A0#include > : > : +#if !defined(__arm__) > : =A0void * > : =A0memmove(void *dest, const void *src, size_t n) > : =A0{ > : @@ -36,3 +37,4 @@ memmove(void *dest, const void *src, siz > : =A0 =A0 =A0 bcopy(src, dest, n); > : =A0 =A0 =A0 return (dest); > : =A0} > : +#endif > > Ummm, usually we don't bother to even include the .c file in cases > like this... =A0Is it this way in -head? > > > Warner > --=20 When bad men combine, the good must associate; else they will fall one by one, an unpitied sacrifice in a contemptible struggle. Edmund Burke