From owner-freebsd-fs@FreeBSD.ORG  Tue Jul 27 12:30:04 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B3B1C1065780
	for <freebsd-fs@hub.freebsd.org>; Tue, 27 Jul 2010 12:30:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9BC938FC18
	for <freebsd-fs@hub.freebsd.org>; Tue, 27 Jul 2010 12:30:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6RCU4Wx010118
	for <freebsd-fs@freefall.freebsd.org>; Tue, 27 Jul 2010 12:30:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6RCU4td010099;
	Tue, 27 Jul 2010 12:30:04 GMT (envelope-from gnats)
Date: Tue, 27 Jul 2010 12:30:04 GMT
Message-Id: <201007271230.o6RCU4td010099@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: Andriy Gapon <avg@icyb.net.ua>
Cc: 
Subject: Re: bin/148296: [zfs] [loader] [patch] Very slow probe in
	/usr/src/sys/boot/zfs/zfs.c
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Andriy Gapon <avg@icyb.net.ua>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jul 2010 12:30:04 -0000

The following reply was made to PR bin/148296; it has been noted by GNATS.

From: Andriy Gapon <avg@icyb.net.ua>
To: Jimmy Olgeni <olgeni@FreeBSD.org>
Cc: "Andrey V. Elsukov" <bu7cher@yandex.ru>, bug-followup@FreeBSD.org,
        Norikatsu Shigemura <nork@FreeBSD.org>
Subject: Re: bin/148296: [zfs] [loader] [patch] Very slow probe in /usr/src/sys/boot/zfs/zfs.c
Date: Tue, 27 Jul 2010 15:24:21 +0300

 on 27/07/2010 15:06 Jimmy Olgeni said the following:
 > 
 > On Mon, 26 Jul 2010, Andriy Gapon wrote:
 > 
 >> I still think that we need a method for querying partition scheme and
 >> available
 >> partitions for a disk.  Perhaps for "biosdisk" only at this point.
 > 
 > I poked around a bit...
 > 
 > If we #include "../i386/libi386/libi386.h" (which seems a bit ugly here)
 > then we can examine the partition layout using _data._gpt.gpt_nparts and
 > _data._gpt.gpt_partitions from struct open_disk:
 > 
 >   struct i386_devdesc *desc = ((struct i386_devdesc
 > *)(files[fd].f_devdata));
 > 
 >   struct open_disk *od = desc->d_kind.biosdisk.data;
 > 
 >   /* get actual partition count and types */
 > 
 > However, struct open_disk and gpt_part are local to biosdisk.c, so they
 > should probably be moved to a header.
 > 
 > Maybe struct open_disk could be moved to stand.h where struct open_file
 > already resides?
 > 
 > In that case we would only need to pull i386_devdesc from libi386.h here.
 
 Well, we could have some accessor functions that would provide the information
 rather than directly poking the internal disk structures...
 
 -- 
 Andriy Gapon