From owner-freebsd-current@FreeBSD.ORG  Mon Jun  7 20:22:18 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EA82216A4CE
	for <current@freebsd.org>; Mon,  7 Jun 2004 20:22:18 +0000 (GMT)
Received: from email07.aon.at (WARSL402PIP8.highway.telekom.at [195.3.96.97])
	by mx1.FreeBSD.org (Postfix) with SMTP id 1E7F143D49
	for <current@freebsd.org>; Mon,  7 Jun 2004 20:22:18 +0000 (GMT)
	(envelope-from shoesoft@gmx.net)
Received: (qmail 636654 invoked from network); 7 Jun 2004 20:07:44 -0000
Received: from m106p004.dipool.highway.telekom.at (HELO ?62.46.3.36?)
	([62.46.3.36]) (envelope-sender <shoesoft@gmx.net>)
	by 172.18.5.236 (qmail-ldap-1.03) with SMTP
	for <rwatson@freebsd.org>; 7 Jun 2004 20:07:44 -0000
From: Stefan Ehmann <shoesoft@gmx.net>
To: Robert Watson <rwatson@freebsd.org>
In-Reply-To: <Pine.NEB.3.96L.1040607153907.88690C-100000@fledge.watson.org>
References: <Pine.NEB.3.96L.1040607153907.88690C-100000@fledge.watson.org>
Content-Type: text/plain
Message-Id: <1086638862.724.2.camel@taxman>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Mon, 07 Jun 2004 22:07:42 +0200
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
Subject: Re: esd leaking file descriptors
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2004 20:22:19 -0000

On Mon, 2004-06-07 at 21:40, Robert Watson wrote:
> On Mon, 7 Jun 2004, Brian Feldman wrote:
> 
> > > I just tried a kernel from June, 1st: esd doesn't leak any file
> > > descriptors. So it's definitely a CURRENT problem.
> > > 
> > > I couldn't spot anything suspicous using ktrace (That is no notable
> > > difference compared to the other machine).
> > > 
> > > Here are two excerpts from kdump output that basically repeat all the
> > > time:
> > 
> > I see a lot of accept(2) there... I think it's a good possibility Robert
> > accidentally broke accept[1]()'s error cleanup.  It seems that the file
> > is dropped but the fd is left sitting around in a half-allocated state. 
> > Many of those 'goto done;'s should be 'goto noconnection;'s, I believe. 
> 
> That's what I was wondering -- it looks like the 'goto done's following
> falloc()'s failure check should be "goto noconnection".  Here's a patch
> that cleans that up, but may not be perfect.

I get a panic when trying to access esd now:
panic: free address has not been allocated