From owner-cvs-all  Mon Mar 24  8:35:56 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5BEC937B401; Mon, 24 Mar 2003 08:35:52 -0800 (PST)
Received: from mail.imp.ch (mail.imp.ch [157.161.1.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9375B43F3F; Mon, 24 Mar 2003 08:35:50 -0800 (PST)
	(envelope-from mb@imp.ch)
Received: from cvs.imp.ch (cvs.imp.ch [157.161.4.9])
	by mail.imp.ch (8.12.6/8.12.3) with ESMTP id h2OGZnfX087018;
	Mon, 24 Mar 2003 17:35:49 +0100 (CET)
	(envelope-from Martin.Blapp@imp.ch)
Date: Mon, 24 Mar 2003 17:35:49 +0100 (CET)
From: Martin Blapp <mb@imp.ch>
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>
Cc: Martin Blapp <mbr@FreeBSD.org>, "" <src-committers@FreeBSD.org>,
	"" <cvs-src@FreeBSD.org>, "" <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/contrib/isc-dhcp/client dhclient.c
In-Reply-To: <20030324160604.GB1911@madman.celabo.org>
Message-ID: <20030324170856.O21003@cvs.imp.ch>
References: <200303232329.h2NNTaI5089971@repoman.freebsd.org>
 <20030324160604.GB1911@madman.celabo.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Status: No, hits=-20.2 required=5.0
	tests=IN_REP_TO,QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES,
	      REPLY_WITH_QUOTES
	version=2.50
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


Hi,

> Are you sure that all values of pid_t can be represented in a signed
> int?

sys/alpha/include/ansi.h:#define        _BSD_PID_T_     int                     /* process [group] */
sys/i386/include/ansi.h:#define _BSD_PID_T_     int                     /* process [group] */
sys/sys/types.h:typedef _BSD_PID_T_     pid_t;          /* process id */

>
> +       pid_t oldpid;
> !                       e = fscanf(pidfd, "%d", &oldpid);
>
> I'd probably opt to do the fscanf with an unsigned long, and then cast
> the value to (pid_t).  *shrug*

or use a unsigned int for it ? Will we have to change this for later ?

Martin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message