From owner-freebsd-current Sat Feb 27 7:31:11 1999 Delivered-To: freebsd-current@freebsd.org Received: from peach.ocn.ne.jp (peach.ocn.ne.jp [210.145.254.87]) by hub.freebsd.org (Postfix) with ESMTP id 9FA4814F2F for ; Sat, 27 Feb 1999 07:29:41 -0800 (PST) (envelope-from dcs@newsguy.com) Received: from newsguy.com by peach.ocn.ne.jp (8.9.1a/OCN) id AAA18002; Sun, 28 Feb 1999 00:26:43 +0900 (JST) Message-ID: <36D80748.2F8F2EBA@newsguy.com> Date: Sat, 27 Feb 1999 23:55:04 +0900 From: "Daniel C. Sobral" X-Mailer: Mozilla 4.5 [en] (Win98; I) X-Accept-Language: pt-BR,ja MIME-Version: 1.0 To: Bruce Evans Cc: sos@freebsd.dk, beyssac@enst.fr, freebsd-current@FreeBSD.ORG, grog@lemis.com, sheldonh@iafrica.com Subject: Re: IDE CDROM not found with PIIX4 chipset, -current kernel References: <199902270820.TAA24763@godzilla.zeta.org.au> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans wrote: > > There's only one, at least in my version. There is the PC98 one you removed, and then this one in atapi_request_immediate(): > /* Wait for data i/o phase. */ > for (cnt=20000; cnt>0; --cnt) > if (((inb (ata->port + AR_IREASON) & (ARI_CMD | ARI_IN)) | > (inb (ata->port + AR_STATUS) & ARS_DRQ)) != PHASE_CMDOUT) > break; > > I sent this in for review a year or so ago, but received no reply. > The main points are that it honours ATA timing in atapi_wait() and > checks for ARS_BUSY in atapi_wait(). This hopefully makes bogus checks > like the one in rev.1.22 unnecessary (status 0xff has ARS_BSY set so it > is invalid). I haven't tested the PC98 case. I removed PC98 code that > seems to only compensate for bugs in atapi_wait(). Looks reasonable to me, but I haven't read the specs in two years. Still, from the symptoms people described, I would urge anyone with trouble to test this patch. I realize sos is introducing a new driver soon, but, at the very least, this would be a -stable material. -- Daniel C. Sobral (8-DCS) dcs@newsguy.com dcs@freebsd.org "To make it absolutely clear: you stand on the wrong end of my blasters, so you better get lost before I start target practice!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message