From owner-cvs-all Tue Dec 31 13:49: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3A7537B401 for ; Tue, 31 Dec 2002 13:49:07 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 1782F43ED8 for ; Tue, 31 Dec 2002 13:49:07 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 90485 invoked by uid 1000); 31 Dec 2002 21:49:08 -0000 Date: Tue, 31 Dec 2002 13:49:08 -0800 (PST) From: Nate Lawson To: "Alan L. Cox" Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h In-Reply-To: <3E120AAF.539CB4F1@imimic.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 31 Dec 2002, Alan L. Cox wrote: > Nate Lawson wrote: > > Please use the non-underscore, exported mtx_* routines. The macros expand > > to the same thing unless you're doing something strange w/ file and line > > (but I don't see that in your patch). > > Yes, they expand to rather useless information: line X of _vm_map_lock. > As I've written it, any messages will report the call site of > _vm_map_lock, which is what we want to know. Thanks for correcting me. Any idea why the non-underscore funcs can't use a more useful value like __LINE__? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message