From owner-freebsd-current@FreeBSD.ORG  Wed Jul 13 21:08:16 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 338B916A41C
	for <freebsd-current@freebsd.org>; Wed, 13 Jul 2005 21:08:16 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz
	[60.234.149.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BE3BE43D4C
	for <freebsd-current@freebsd.org>; Wed, 13 Jul 2005 21:08:15 +0000 (GMT)
	(envelope-from thompsa@freebsd.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 1D81D1CCD6; Thu, 14 Jul 2005 09:08:11 +1200 (NZST)
Date: Thu, 14 Jul 2005 09:08:11 +1200
From: Andrew Thompson <thompsa@freebsd.org>
To: Niki Denev <nike_d@cytexbg.com>
Message-ID: <20050713210811.GA60866@heff.fud.org.nz>
References: <200507121026.16664.nike_d@cytexbg.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200507121026.16664.nike_d@cytexbg.com>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-current@freebsd.org
Subject: Re: add a few informative printfs to if_bridge.c?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2005 21:08:16 -0000

On Tue, Jul 12, 2005 at 10:26:16AM +0300, Niki Denev wrote:
> Hello all,
> 
> So, i have a proposition to add some informative printfs to if_bridge code,
> because returning "Invalid argument" is not so self explanatory, especially
> in the wrong MTU case. I think that most of the returns in bridge_ioctl_add(),
> could benefit from additional printf with more information.
> What do you think?
> 

Ive added a message for the incorrect MTU case and also relaxed the
requirements a little. The bridge will take the MTU of the first member
interface rather than being hardcoded at 1500, all members are still
required to have the exact same MTU.


cheers,

Andrew