From owner-freebsd-ports@freebsd.org Sun Jul 5 08:36:47 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9EC513651EF for ; Sun, 5 Jul 2020 08:36:47 +0000 (UTC) (envelope-from timp87@gmail.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B029p4vNJz4f9M; Sun, 5 Jul 2020 08:36:46 +0000 (UTC) (envelope-from timp87@gmail.com) Received: by mail-ed1-x532.google.com with SMTP id b15so31923352edy.7; Sun, 05 Jul 2020 01:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z/WNUQR2NtCF8jaOaGS7rbd/oXMW8Zm2CSsL3VoI7Rc=; b=UH+nmws3nFnYgCl3KCXA36H+dlD6brF3LK1ZVloghGXtbnti9PvIRRSJ6N0bfVx2em 6tBVsra1Mopvyx75OTDue2oNXn8eygii3GEnHv5YE2BaLk7m4RNVh1SjxKMQw1zq79YB tg6Zp7OTxq7rNKtzYF+l4Hd6Ie1mMYjBelUrOz3Ik4ZDvvlqnrEVys9lIGyv4+PMbEQL b5YCYdqPxn8AtIMI+BhHc8/43H9chq69ZFWWRzXmiwhQoPi+62AtN4iEbENm4Dgm0u30 S2mKpYRpjQ6c/rjOqnsWMoFEs8iQ1M4lkbDIuwWzAPRObeCOLkIIvGcQfRU9JPssBVes xrRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z/WNUQR2NtCF8jaOaGS7rbd/oXMW8Zm2CSsL3VoI7Rc=; b=k2SAlCufMiYYftfivlIQrb4HO/nHxjS/XJMb+nS+Ow2YanN2aB3WXh/EJ3LmvGUVRB C0NLThvEZ6//iH7+YnCj0B8r2bogCVAQFY5tIRs5fs3jsxyDYflJBnCKufyNz9rmZx5R sfAcA7+PKGvZEqpa2+tNYGeJtgDL4D5Q63Npb1m1kbU9S0d9eIx3cjXAUYi+XLUZCuVD H2mvoMCD4VqxxpdPxdOy793lVzTcAfJp2zZKx6yBrHgskjx5kjzY3oLwBlyWaM4IwuXu JcuZQxZbe35wTk7GmD4/rGO9e42zvebmfO6uY03pUBqYExzS3DHLuKPF/SeVxgG24+Sf en7w== X-Gm-Message-State: AOAM531PHN5c8aSc6WKuFXaheqZUGpwDtp+i2H0qh6lzeeXH/NfpO2u0 xCer57mZwmEXwfuUUWrFlBOCcMth942PQAn66CdkHISO X-Google-Smtp-Source: ABdhPJyYAlbnwG6spSfAJPMguNWo0jsbj4ufaNyKQKCNm+8CQhzgeaR7BWJbEqf0wFGB/wQ36pYNEOcAFrltaAr9iRE= X-Received: by 2002:a05:6402:359:: with SMTP id r25mr25209732edw.177.1593938204940; Sun, 05 Jul 2020 01:36:44 -0700 (PDT) MIME-Version: 1.0 References: <20200703.035403.856368268140192104.hrs@FreeBSD.org> <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org> <20200704.140946.1661194655626577558.hrs@FreeBSD.org> In-Reply-To: <20200704.140946.1661194655626577558.hrs@FreeBSD.org> From: Pavel Timofeev Date: Sun, 5 Jul 2020 11:36:17 +0300 Message-ID: Subject: Re: set_rcvar() function use? To: Hiroki Sato Cc: 0mp@freebsd.org, ports-list freebsd , manu@freebsd.org, walter.von.entferndt@posteo.net X-Rspamd-Queue-Id: 4B029p4vNJz4f9M X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=UH+nmws3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of timp87@gmail.com designates 2a00:1450:4864:20::532 as permitted sender) smtp.mailfrom=timp87@gmail.com X-Spamd-Result: default: False [-2.89 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.988]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; NEURAL_HAM_LONG(-1.02)[-1.018]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::532:from]; NEURAL_HAM_SHORT(-0.88)[-0.879]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2020 08:36:47 -0000 =D1=81=D0=B1, 4 =D0=B8=D1=8E=D0=BB. 2020 =D0=B3. =D0=B2 08:11, Hiroki Sato = : > Mateusz Piotrowski <0mp@FreeBSD.org> wrote > in <34921b6e-ce3a-13e4-0cc1-3ca47b5a9cef@FreeBSD.org>: > > 0m> > I am planning to revisit the multi-instance support shortly becaus= e > I > 0m> > am using it for a long time and I think it is useful. While I did > 0m> > not receive a strong objection to it so far, it is also true that > 0m> > adopting the set_rcvar() style was not discussed properly. I woul= d > 0m> > like more feedback before moving forward. > 0m> > 0m> AFAIR, manu@ was concerned at some point that using set_rcvar() > extensively > 0m> might result in slowdowns on embedded systems. > > A discussion in the past about the performance was an additional > fork(2) when using set_rcvar() for rc_var=3D`set_rcvar`. The use case > of the resurrected one is "set_rcvar A B" as a replacement of "A=3DB", > and it does not involve a subshell. > > I agree that the performance perspective should also be discussed, > though. The current rc.subr and network.subr already have more > expensive operations, so we might want to gather profiling > information. > > Thanks a lot for the answers! It's great that the only existed concern is not a problem anymore for the resurrected "set_rcvar A B" form. IMO features like setting variable description and ability to "ask" rc script what variables/options are available are really great even without multi-instance support.