From owner-svn-src-user@FreeBSD.ORG Wed Oct 15 20:48:10 2008 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C23F31065686; Wed, 15 Oct 2008 20:48:10 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from k7.mavetju.org (ppp121-44-151-188.lns10.syd7.internode.on.net [121.44.151.188]) by mx1.freebsd.org (Postfix) with ESMTP id 3B79B8FC18; Wed, 15 Oct 2008 20:48:10 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by k7.mavetju.org (Postfix, from userid 1001) id C6E344503D; Thu, 16 Oct 2008 07:27:53 +1100 (EST) Date: Thu, 16 Oct 2008 07:27:53 +1100 From: Edwin Groothuis To: John Baldwin Message-ID: <20081015202753.GO71453@mavetju.org> References: <200810142351.m9ENpUJ4019023@svn.freebsd.org> <200810151054.59231.john@baldwin.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810151054.59231.john@baldwin.cx> User-Agent: Mutt/1.4.2.3i Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r183899 - user/edwin/top/top-3.8b1/usr.bin/top X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2008 20:48:10 -0000 On Wed, Oct 15, 2008 at 10:54:58AM -0400, John Baldwin wrote: > On Tuesday 14 October 2008 07:51:30 pm Edwin Groothuis wrote: > > Author: edwin > > Date: Tue Oct 14 23:51:30 2008 > > New Revision: 183899 > > URL: http://svn.freebsd.org/changeset/base/183899 > > > > Log: > > Display the original command between ()'s just like the old top did > > when the command and the first argument of the command-line-arguments > > don't match. > > > > According to include/sys/user.h, PS_INMEM is obsoleted in favour > > of P_INMEM, not the other way around. > > This change is not quite correct. You should use P_INMEM for <= 4 and >= 7, > and PS_INMEM for >= 5 and <= 6. Aha, that explains the strange combination of comments I saw in the include file and the piece of code. Thanks for spotting this! Edwin -- Edwin Groothuis Website: http://www.mavetju.org/ edwin@mavetju.org Weblog: http://www.mavetju.org/weblog/