From owner-cvs-src@FreeBSD.ORG  Thu Nov  4 11:10:27 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5281016A4CE; Thu,  4 Nov 2004 11:10:27 +0000 (GMT)
Received: from shrike.submonkey.net (cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com
	[81.103.67.204])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E1AA843D55; Thu,  4 Nov 2004 11:10:26 +0000 (GMT)
	(envelope-from setantae@submonkey.net)
Received: from setantae by shrike.submonkey.net with local (Exim 4.43
	(FreeBSD))	id 1CPfVZ-000B3q-VO; Thu, 04 Nov 2004 11:10:25 +0000
Date: Thu, 4 Nov 2004 11:10:25 +0000
From: Ceri Davies <ceri@submonkey.net>
To: "David E. O'Brien" <obrien@FreeBSD.org>
Message-ID: <20041104111025.GG57641@submonkey.net>
Mail-Followup-To: Ceri Davies <ceri@submonkey.net>,
	"David E. O'Brien" <obrien@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200411040128.iA41ShNQ055582@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="kWb2NB+iM6KO7H8g"
Content-Disposition: inline
In-Reply-To: <200411040128.iA41ShNQ055582@repoman.freebsd.org>
X-PGP: finger ceri@FreeBSD.org
User-Agent: Mutt/1.5.6i
Sender: Ceri Davies <setantae@submonkey.net>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Nov 2004 11:10:27 -0000


--kWb2NB+iM6KO7H8g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 04, 2004 at 01:28:43AM +0000, David E. O'Brien wrote:
> obrien      2004-11-04 01:28:43 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     usr.sbin/sysinstall  config.c=20
>   Log:
>   Stop listening to bug reports with wrong solutions and commit a fix to =
the '
>   problem I know will work.

This line now gets written to /tmp/exports:

> | @@ -876,7 +876,7 @@ configNFSServer(dialogMenuItem *self)
> |  	    vsystem("echo '#/a      -maproot=3D0  -network 10.0.1.0 -mask 255=
=2E255.248.0' >> /etc/exports");
> |  	    vsystem("echo '#' >> /etc/exports");
> |  	    vsystem("echo '# You should replace these lines with your actual =
exported filesystems.' >> /etc/exports");
> | -	    vsystem("echo '# Note that BSD\'s export syntax is \"host-centric=
\" vs. Sun\'s \"FS-centric\" one.' >> /etc/exports");
> | +	    vsystem("echo \"# Note that BSD's export syntax is 'host-centric'=
 vs. Sun's 'FS-centric' one.\" >> /tmp/exports");

Also, wouldn't it just be easier to open() /etc/exports and write to it
that way?  I understand that this isn't how this is done anywhere else
in sysinstall, but why not?

Ceri
--=20

--kWb2NB+iM6KO7H8g
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBig4hocfcwTS3JF8RAvvHAKCnjpd8pN4cgb6lRLbrxTIiO6Zg1gCgmrKu
G5wC93y6f65TEYdYfeDY5vs=
=airX
-----END PGP SIGNATURE-----

--kWb2NB+iM6KO7H8g--