From owner-freebsd-arm@FreeBSD.ORG Mon Sep 22 05:49:06 2008 Return-Path: Delivered-To: arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D15C106566C for ; Mon, 22 Sep 2008 05:49:06 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from ns.kevlo.org (kevlo.org [220.128.136.52]) by mx1.freebsd.org (Postfix) with ESMTP id 2B8E48FC1D for ; Mon, 22 Sep 2008 05:49:03 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from [127.0.0.1] (ns.kevlo.org [220.128.136.52]) by ns.kevlo.org (8.14.3/8.14.3) with ESMTP id m8M5LFWA027206; Mon, 22 Sep 2008 13:21:16 +0800 (CST) (envelope-from kevlo@FreeBSD.org) X-Authentication-Warning: ns.kevlo.org: Host ns.kevlo.org [220.128.136.52] claimed to be [127.0.0.1] From: Kevin Lo To: "M. Warner Losh" In-Reply-To: <20080921.202430.-893473872.imp@bsdimp.com> References: <20080921.202430.-893473872.imp@bsdimp.com> Content-Type: text/plain Date: Mon, 22 Sep 2008 13:23:23 +0800 Message-Id: <1222061003.10402.4.camel@nsl> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Cc: arm@FreeBSD.org Subject: Re: Code review request X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2008 05:49:06 -0000 M. Warner Losh wrote: > I did this a long time ago, but never committed it. I believe that > this works. It uses the common bus space methods to implement the > default arm bus space methods. > > Comments? You're missing the bs_ind.h header file and this patch doesn't apply cleanly against -HEAD. > Warner Kevin