From owner-freebsd-arch@freebsd.org Mon Mar 25 01:34:47 2019 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 633ED154CDDD for ; Mon, 25 Mar 2019 01:34:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AA6BC71A68 for ; Mon, 25 Mar 2019 01:34:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id B1F5D154CDD9; Mon, 25 Mar 2019 01:34:45 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FD72154CDD0 for ; Mon, 25 Mar 2019 01:34:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2CB6971A3E for ; Mon, 25 Mar 2019 01:34:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id z17so8500701qts.13 for ; Sun, 24 Mar 2019 18:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VdvE+KGTsGuE+pmu8fmbNeAK396tsYhHvb0KhY6v+4I=; b=Ofq25uzEk1NlSjQ3rMs7Ozux1kSDdYUTjI3W/6fHHn0ZeJQW9+6hvSfQvtrGFUeD31 nvYhhwGiA4OqA3FIRyMbA++7C4HlccXjdtk3kaqsEKZyBC3pl9t0Wt4UQsW600rlTexZ /vJsbjK1WagIthMetsr1Db6t8HT06k6oROesrB8i0vfCabXVY8Ra1VI0E2jZ04nKCNh2 tvmJU4e5v3llzml2CiUkXQgqjM8Z4aZLsly2g1TElD/RXDz21crXLyFxUkQQEq9YilJ/ lvAB5hwE3Qn2gN21TWJQdKCnGC2UMcYaB+KVS2WCsRlua14YIzdNmlcVec3zDs/RDoEB C5tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VdvE+KGTsGuE+pmu8fmbNeAK396tsYhHvb0KhY6v+4I=; b=sWTe94ZaenrGsaODIFe8NZ+c3JIlRrUf4dxEfg60Z8PFBk0L9XJL6SzzPCvmPZkyj+ pl7KZfuIo2e3ZpouBhQ9dMNmQqiVqeWUfHQtP789PbqvQJTa/khWa2MwMCx9Ej+VHNst nK8dof1tuMYLiepu66++y4b6/YunCdSEWirwJIKIxgHAuy8GuIyW+dkgFWusdeImz3DF XUDyeYNjzl5n0Re+Ob4jlg1TuH8d0tw16rDjZX6JnNpBsQyjY19LZwALwjFCwd1XPuur tQ8F2MBghAsyXNjv+EejDW7cMKsmn/FXm+9pNA6mQXWidXkkGrml8ED1tdXZca31NP1C ppWg== X-Gm-Message-State: APjAAAW1YEnSmF4smJqKp4yBx3UlVP53PtasAB1aM/dGybYf23aes7Z3 Q0P7izkEcoTFGm7uRmRB4UOpTP2UR1KNw1SPnxxXZg== X-Google-Smtp-Source: APXvYqyw6NMttqVIpT4q/GN+FUZVdHFkry4svbU5lNqCWmDZlNL4WX98uiS3Znzw3t/0M0PXrtPpAPki+qmtKQyY5Dc= X-Received: by 2002:ac8:4685:: with SMTP id g5mr11735232qto.242.1553477684110; Sun, 24 Mar 2019 18:34:44 -0700 (PDT) MIME-Version: 1.0 References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> <20190324090103.GO1923@kib.kiev.ua> <20190325000241.GS1923@kib.kiev.ua> <6badde15-d8f4-c4ea-2061-0d3c80c6e82a@bluestop.org> In-Reply-To: <6badde15-d8f4-c4ea-2061-0d3c80c6e82a@bluestop.org> From: Warner Losh Date: Sun, 24 Mar 2019 19:34:33 -0600 Message-ID: Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" To: Rebecca Cran Cc: Konstantin Belousov , FreeBSD Hackers , "freebsd-arch@freebsd.org" X-Rspamd-Queue-Id: 2CB6971A3E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 01:34:47 -0000 On Sun, Mar 24, 2019 at 6:59 PM Rebecca Cran via freebsd-arch < freebsd-arch@freebsd.org> wrote: > On 3/24/19 6:02 PM, Konstantin Belousov wrote: > > > > > Having efi_update_loader alone would be fine, but I doubt that this > > script can do much except in situations where a lot of pre-assumptions > > are true. I believe that despite all the efforts put into efibootmgr > > and installer, it is hard/impossible to make the script not dangerous, > > except if the whole configuration was created by our installer. > > > It currently does nothing except if there is one or more partitions of > type 'efi' that contain a \efi\boot\boot${arch}.efi or > \efi\freebsd\loader.efi that contain strings from the FreeBSD boot1.efi > or loader.efi. Perhaps that's too much guessing, and we should only ever > update /boot/msdos or /boot/efi or wherever we decide to mount it. > Right. We need a standard location (that maybe can be overridden, like you can with /boot, if you really want), and that's likely the first order of business. I don't think we should be second guessing, though. And we shouldn't be touching \efi\boot anything unless specifically instructed to do so. I'm deeply uncomfortable with guessing whether or not to do something... Warner