From owner-freebsd-bugs Tue Jul 16 7: 0:20 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76F6437B401 for ; Tue, 16 Jul 2002 07:00:06 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F20AF43E67 for ; Tue, 16 Jul 2002 07:00:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6GE04JU097520 for ; Tue, 16 Jul 2002 07:00:04 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6GE04Es097519; Tue, 16 Jul 2002 07:00:04 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F0CD37B400 for ; Tue, 16 Jul 2002 06:58:46 -0700 (PDT) Received: from smtp.www-service.de (smtp.www-service.de [212.77.161.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D86443E42 for ; Tue, 16 Jul 2002 06:58:45 -0700 (PDT) (envelope-from thz@Lennartz-electronic.de) Received: from swd2.tue.le (pD95033C1.dip.t-dialin.net [217.80.51.193]) by smtp.www-service.de (8.11.6/8.11.6) with ESMTP id g6GFHhX19480 for ; Tue, 16 Jul 2002 17:17:44 +0200 Received: from mezcal.tue.le (mezcal.tue.le [192.168.201.20]) by swd2.tue.le (8.12.3/8.12.3) with ESMTP id g6GDvBXj049671 for ; Tue, 16 Jul 2002 15:57:11 +0200 (CEST) (envelope-from thz@mezcal.tue.le) Received: from mezcal.tue.le (localhost [127.0.0.1]) by mezcal.tue.le (8.12.3/8.12.3) with ESMTP id g6GDvBUM072781 for ; Tue, 16 Jul 2002 15:57:11 +0200 (CEST) (envelope-from thz@mezcal.tue.le) Received: (from thz@localhost) by mezcal.tue.le (8.12.3/8.12.3/Submit) id g6GDvBIs072780; Tue, 16 Jul 2002 15:57:11 +0200 (CEST) (envelope-from thz) Message-Id: <200207161357.g6GDvBIs072780@mezcal.tue.le> Date: Tue, 16 Jul 2002 15:57:11 +0200 (CEST) From: Thomas Zenker Reply-To: Thomas Zenker To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/40655: patch: sysinstall assigns partition a to swap Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 40655 >Category: bin >Synopsis: patch: sysinstall assigns partition a to swap >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 16 07:00:04 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Thomas Zenker >Release: FreeBSD 4.6-RELEASE i386 >Organization: >Environment: System: FreeBSD mezcal.tue.le 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Mon Jun 10 11:22:51 CEST 2002 thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL i386 applies to all versions of sysinstall >Description: scripted partitioning of a disk can lead to a swap partition assigned to partition a (normally root). The problem is caused by not reseting a flag, so CHUNK_IS_ROOT contaminates the next chunk/slice. >How-To-Repeat: swap is first partition in a slice after assigning the root partition in the previous slice. >Fix: Following patch applies to current and stable. Index: label.c =================================================================== RCS file: /usr/cvs/FreeBSD/src/usr.sbin/sysinstall/label.c,v retrieving revision 1.118 diff -u -r1.118 label.c --- label.c 7 Jun 2002 15:32:05 -0000 1.118 +++ label.c 16 Jul 2002 13:25:34 -0000 @@ -1361,7 +1361,7 @@ char *cp; PartType type; PartInfo *p; - u_long flags = 0; + u_long flags; int i, status; Device **devs; Disk *d; @@ -1406,6 +1406,7 @@ else { Chunk *tmp; + flags = 0; if (!strcmp(typ, "swap")) { type = PART_SWAP; strcpy(mpoint, "SWAP"); @@ -1414,8 +1415,6 @@ type = PART_FILESYSTEM; if (!strcmp(mpoint, "/")) flags |= CHUNK_IS_ROOT; - else - flags &= ~CHUNK_IS_ROOT; } if (!sz) sz = space_free(c1); >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message