From owner-freebsd-qa@FreeBSD.ORG Wed Oct 1 17:37:41 2003 Return-Path: Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E4F316A4B3; Wed, 1 Oct 2003 17:37:41 -0700 (PDT) Received: from avscan1.sentex.ca (avscan1.sentex.ca [199.212.134.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72D2343FEC; Wed, 1 Oct 2003 17:37:40 -0700 (PDT) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18]) by avscan1.sentex.ca (8.12.9p2/8.12.9) with ESMTP id h920bdl7094793; Wed, 1 Oct 2003 20:37:39 -0400 (EDT) (envelope-from mike@sentex.net) Received: from simian.sentex.net (simeon.sentex.ca [192.168.43.27]) by lava.sentex.ca (8.12.9p1/8.12.9) with ESMTP id h920bcdK089893; Wed, 1 Oct 2003 20:37:38 -0400 (EDT) (envelope-from mike@sentex.net) Message-Id: <6.0.0.22.0.20031001203933.06fcb2d8@209.112.4.2> X-Sender: mdtpop@209.112.4.2 (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.0.22 Date: Wed, 01 Oct 2003 20:40:56 -0400 To: Erik Trulsson , Murray Stokely , stable@freebsd.org, qa@freebsd.org From: Mike Tancsa In-Reply-To: <20031002002303.GA33156@falcon.midgard.homeip.net> References: <20030929151905.GD3743@freebsdmall.com> <20030929160905.GB42388@falcon.midgard.homeip.net> <20031001235809.GY91404@gsmx07.alcatel.com.au> <20031002002303.GA33156@falcon.midgard.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Virus-Scanned: by Sentex Communications (avscan1/20021227) Subject: Re: FreeBSD 4.9 RC1 (i386) now available X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2003 00:37:41 -0000 Is http://docs.freebsd.org/cgi/getmsg.cgi?fetch=1132682+0+current/cvs-all http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ata/ata-isa.c.diff?r1=1.4.2.2&r2=1.4.2.3 not the commit that is needed ? ---Mike At 08:23 PM 01/10/2003, Erik Trulsson wrote: >On Thu, Oct 02, 2003 at 09:58:10AM +1000, Peter Jeremy wrote: > > On 2003-Sep-29 18:09:05 +0200, Erik Trulsson > wrote: > > >On Mon, Sep 29, 2003 at 08:19:05AM -0700, Murray Stokely wrote: > > >> Not all FTP sites have the first release candidate, but it is at least > > >> available from ftp.freebsd.org. Please download and install this > > >> candidate and help us find bugs BEFORE we call it 4.9-RELEASE. > > > > > > > > >You mean apart from the minor bug that non-pci kernels using ata won't > even > > >compile, and hasn't worked for the last three weeks or so? > > > > > > > > >See > > > > > >http://docs.freebsd.org/cgi/getmsg.cgi?fetch=44649+0+archive/2003/freeb > sd-stable/20030928.freebsd-stable > > > > > >or > > > > > >http://docs.freebsd.org/cgi/getmsg.cgi?fetch=816008+0+archive/2003/cvs- > all/20030921.cvs-all > > > > > >for details and a patch. > > > > Whilst both Erik and I independently came up with the same patch, upon > > reflection, I'm not sure that this is the correct patch. None of the > > callers to ata_dmastart() check for a return value and therefore this > > probably should be a void function - so the code in ata-isa.c is > > correct and the remaining declaration and definitions are incorrect. > >The "real" version of ata_dmastart() found in ata-dma.c does return >different values for different situations, so for compatibility that >function would also need to be modified, which I am not sure is a good >idea. >You are correct in that the return value is currently not checked by >the callers to ata_dmastart, but perhaps it should be? >I believe the return value probably should be kept, in case some future >caller wants to check how the call succeeded, but for an authoritative >answer you would have to ask one of the ATA-experts. > >Anyway, it doesn't really matter. The code compiles with the patch, >and a return value that is ignored is quite harmless, so any changes >should wait until after 4.9-RELEASE at least. > > > > > In either case, I would request that this be fixed before 4.9-RELEASE. > >It has already been fixed. The commit to fix it was made by luoqi about >20 hours ago. > > >-- > >Erik Trulsson >ertr1013@student.uu.se >_______________________________________________ >freebsd-stable@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-stable >To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org"