From owner-svn-src-projects@FreeBSD.ORG  Sat Jun  9 23:51:26 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C994E1065670;
	Sat,  9 Jun 2012 23:51:26 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from fallbackmx06.syd.optusnet.com.au
	(fallbackmx06.syd.optusnet.com.au [211.29.132.8])
	by mx1.freebsd.org (Postfix) with ESMTP id 369F98FC08;
	Sat,  9 Jun 2012 23:51:26 +0000 (UTC)
Received: from mail28.syd.optusnet.com.au (mail28.syd.optusnet.com.au
	[211.29.133.169])
	by fallbackmx06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	q59Nk2YI014834; Sun, 10 Jun 2012 09:46:02 +1000
Received: from c122-106-171-232.carlnfd1.nsw.optusnet.com.au
	(c122-106-171-232.carlnfd1.nsw.optusnet.com.au [122.106.171.232])
	by mail28.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	q59NjrFt013126
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 10 Jun 2012 09:45:54 +1000
Date: Sun, 10 Jun 2012 09:45:53 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: "Cherry G. Mathew" <cherry@freebsd.org>
In-Reply-To: <201206091258.q59Cw0Kb033870@svn.freebsd.org>
Message-ID: <20120610094048.Y1188@besplex.bde.org>
References: <201206091258.q59Cw0Kb033870@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r236813 - projects/amd64_xen_pv/sys/amd64/include
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jun 2012 23:51:26 -0000

On Sat, 9 Jun 2012, Cherry G. Mathew wrote:

> Log:
>  Xen's "pseudo-physical" "ram" space is a fragmented by virtue of its bootstrap
>  sequence. vm requires this #define to stitching up the pieces into the
>  kva while booting up. See: vm_page.c:vm_page_startup()
>
>  Approved by:	gibbs (implicit)
>
> Modified:
>  projects/amd64_xen_pv/sys/amd64/include/vmparam.h
>
> Modified: projects/amd64_xen_pv/sys/amd64/include/vmparam.h
> ==============================================================================
> --- projects/amd64_xen_pv/sys/amd64/include/vmparam.h	Sat Jun  9 12:27:30 2012	(r236812)
> +++ projects/amd64_xen_pv/sys/amd64/include/vmparam.h	Sat Jun  9 12:58:00 2012	(r236813)
> @@ -79,7 +79,11 @@
> /*
>  * The physical address space is densely populated.
>  */
> +#ifndef XEN
> #define	VM_PHYSSEG_DENSE
> +#else /* XEN */
> +#define	VM_PHYSSEG_SPARSE
> +#endif

See style(9).  The style bugs here are:
- comment on #else for a short #ifdef
- #ifndef instead of #ifdef when there is an #else
- comment no longer matches code (or the log message).  It applies to the
   whole ifdef, but the ifdef is manifestly for handling address spaces
   that are _not_ densely populated.

Bruce