From owner-svn-ports-head@freebsd.org Mon Aug 24 07:09:15 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C912D9C1271; Mon, 24 Aug 2015 07:09:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B4457110D; Mon, 24 Aug 2015 07:09:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id B28F717B5; Mon, 24 Aug 2015 07:09:15 +0000 (UTC) Date: Mon, 24 Aug 2015 07:09:15 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824070915.GA15244@FreeBSD.org> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96D957F8044D8B647B259802@atuin.in.mat.cc> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 07:09:15 -0000 On Sun, Aug 23, 2015 at 11:43:21PM +0100, Mathieu Arnold wrote: > +--On 23 ao??t 2015 08:56:58 +0000 Alexey Dokuchaev > wrote: > | +# Unfortunately, the code is not GCC 4.2.1 compatible (due to bugs in GCC > | +# itself). Try to use system compiler if it is Clang, otherwise fallback > | +# to modern GCC (on older versions of FreeBSD). > | +.if ${OSVERSION} < 900014 > | +USE_GCC= yes > > OSVERSION < 900014 will always be false. Please, don't add more checks on > unsupported versions. The fact that 8.X had reached its EOL merely means we cannot promise that things won't break. It does not mean we should immediately pull the plug and remove two lines from the Makefile, leaving 8.4 users with a broken port. It's up to maintainers to decide whether it's worth supporting some old FreeBSD version. Keeping around intricate patches and having to rebase and test on every update is a nuisance, so those patches probably deserve to rest in attic now. Two lines in the Makefile are hardly a burden. I typically would try to support as many FreeBSD versions as long the port stays manageable. Often it's not a problem, and is very polite to our users that do not want to upgrade for some reason (e.g. me and my laptop are happy with stable/8 and see no reason to update, as it will likely pessimize work experience without bringing any benefits over 8.4). That said, OSVERSION < 900014 will not always be false. And why do you want to be rude to our users and deliberately break things just because we no longer promise that they will work? ./danfe