Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Feb 2004 17:44:46 -0500
From:      John Baldwin <jhb@FreeBSD.org>
To:        Tim Robbins <tjr@freebsd.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_resource.c
Message-ID:  <200402061744.46011.jhb@FreeBSD.org>
In-Reply-To: <20040206221255.GA54490@cat.robbins.dropbear.id.au>
References:  <200402061930.i16JUCpa011145@repoman.freebsd.org> <20040206221255.GA54490@cat.robbins.dropbear.id.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 06 February 2004 05:12 pm, Tim Robbins wrote:
> On Fri, Feb 06, 2004 at 11:30:12AM -0800, John Baldwin wrote:
> > jhb         2004/02/06 11:30:12 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             kern_resource.c
> >   Log:
> >   - Correct the translation of old rlimit values to properly handle the
> > old RLIM_INFINITY case for ogetrlimit().
> >   - Use %jd and intmax_t to output negative time in usec in calcru().
> >   - Rework getrusage() to make a copy of the rusage struct into a local
> >     variable while holding Giant and then do the copyout from the local
> >     variable to avoid having to have the original process rusage struct
> >     locked while doing the copyout (which would not be safe).  This also
> >     includes a few style fixes from Bruce to getrusage().
>
> Thanks (from the one who added the XXX comment). Can't we use the
> proc lock here though?

No idea.  Haven't looked at doing the p_stats locking or p_cru locking yet.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402061744.46011.jhb>