From owner-freebsd-testing@freebsd.org Mon Aug 6 20:18:38 2018 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2BB71064364 for ; Mon, 6 Aug 2018 20:18:37 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5081389479; Mon, 6 Aug 2018 20:18:37 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x235.google.com with SMTP id r13-v6so11603286ljg.10; Mon, 06 Aug 2018 13:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5Qh4wpbGdACigbSquMVhk4om3HqzjY8vnNN61W2sNA0=; b=IIrWrNOvGCodQyqynElESy3A+D2Yf4cVYSskoSuCjyBSVyhG2V8mnv3Bpr9j1rSxRO mgvGVlUFA+nFgCY7wAviKX3FGs85eg2QygXrKUiDK2S+DtwwwKaydmRA1D076TtS1Xxy cVZduuO3EazeuDFcGbOoqWLGaC8LUb/OG0he8rYGZnSw1NS/aOgJaGFoeDsyRRpuZ8q5 qryyWndwWjIS/hHCzLxBfJtmKl8hxZxvaZlfyTA+Q+JCRY6dxt0JHFFLbgVzrdsv7kD0 viLQACo2fj16l12RtyBfc3HZ97vS/hJVn21/ffZbvADDBTDobGfzbo2d6yVwsFQ7r74W lFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5Qh4wpbGdACigbSquMVhk4om3HqzjY8vnNN61W2sNA0=; b=erJA07FY7ECeWR0KyiGBfZq9JhTYhuMcUYIjt4blaU1jEh80olKMuYOXX1Od/J15kU i8uTKg5UI9631tWIOjdl70j0EMQrLUeentmDB8tbEn9lF9ICgzcc7GBtS8KJvelN7655 YPF8T7rdhOTjQaxZnJfS+OVE2TmwSxA1KE9FfbOmUu+YcuuwH/Ca2ubRcaFVzYycNf72 9VOlO4skm2DB5+J0134cG+SvvVa6EzqzlIIlSRfVyNY7KerC53gtEyugtwBkulptQfA+ j8U0FgulT4Lye0P0YtPtoJckLZQfLRmktvX8UkKowo776NV59b1H5AwTUnpY2rJP+Maf 3Yrg== X-Gm-Message-State: AOUpUlGdnK0EJtM2ZJvr2rtjO95rB7PgnFTlPhKFNeasT4/yuW/TktWj DAHnQeqL2LJh7eZpmQChLbyZhJ6J6uVbXgrC29/whw== X-Google-Smtp-Source: AAOMgpegurR5t/reEb4vtdKB3Pi1QjUJ6NOKE6GOM6bbcWHtU3UceFfMVIa7oo54ACm14p+Xy4Od//c+8gFSB8YWs1s= X-Received: by 2002:a2e:87da:: with SMTP id v26-v6mr13252935ljj.69.1533586715631; Mon, 06 Aug 2018 13:18:35 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Mon, 6 Aug 2018 13:18:35 -0700 (PDT) In-Reply-To: <20180806191406.GA77150@raichu> References: <20180806191406.GA77150@raichu> From: Alan Somers Date: Mon, 6 Aug 2018 14:18:35 -0600 X-Google-Sender-Auth: -whSdT8MAp_594-UiTXQv7eMDtI Message-ID: Subject: Re: Skipping tests that are unimplemented in 32-bit emulation To: Mark Johnston Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 20:18:38 -0000 On Mon, Aug 6, 2018 at 1:14 PM, Mark Johnston wrote: > On Sun, Jul 29, 2018 at 11:23:33AM -0600, Alan Somers wrote: > > I recently tried running the i386 test suite in a chroot on an amd64 > > system. 162 tests failed, and 33 were broken. Some of the failures were > > due to system calls that haven't been implemented in 32-bit emulation. > > setfib(2) is an example. I think it's unlikely that anybody will ever > need > > 32-bit emulation for setfib(2), so perhaps we should just skip the test? > > What's the best way to do that? I can come up with two ways: > > > > 1) At runtime, check the hw.machine sysctl and see if it matches some > > compile time preprocessor constant. I don't know what constant to use, > > though. Checking __amd64__ would only work for i386 binaries on amd64 > > kernels, and not something else like mips binaries on mips64 kernels (I > > don't know if we support that, but I don't want to rule it out). > > > > 2) At buildtime, put an "allowed_architectures=i386" metadata property > into > > the Kyuafile for that test program. This would require support in > > /usr/share/mk/bsd.test.mk. It would also require patching Kyua itself, > > because currently "Kyua config" returns the architecture for which it was > > built, not the one on which it's running. > > > > Thoughts? > > I don't have any particular suggestions, but I'd personally rather avoid > a solution that requires tests to opt-in to running under 32-bit > emulation, which I think excludes 2). I'd be happy to help annotate > any failing tests as required. It bugs me that the test suite currently > doesn't cover such relatively complicated functions as > freebsd32_copy_msg_out(). > I don't think that 2 would necessarily be opt-in, because an undefined value for allowed_architectures is interpreted as meaning "all". It could be opt-out instead. But it could still be a little awkward. Option 1 could be accomplished for atf-c testcases by comparing the value of __LP64__ to a hardcoded list of known 64-bit processors as returned by uname(3). But I don't know how to implement 1 for atf-sh programs. An atf-sh program would need to know the architecture of any binary that it might invoke. Is there anything in /etc indicating what architecture the image was built for? Should we just use "file /lib/libc.so.*"?