From owner-freebsd-stable Thu Mar 13 7:46:32 2003 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3610E37B401 for ; Thu, 13 Mar 2003 07:46:30 -0800 (PST) Received: from bastion.pydo.net (bastion.pydo.net [62.212.97.116]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14EAA43F3F for ; Thu, 13 Mar 2003 07:46:29 -0800 (PST) (envelope-from artur@pydo.org) Received: by bastion.pydo.net (Postfix, from userid 10025) id 0E1A54C252; Thu, 13 Mar 2003 16:46:27 +0100 (CET) Received: from pydo.org (univers2.pydo.org [192.168.0.4]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by bastion.pydo.net (Postfix) with ESMTP id 826F34C250 for ; Thu, 13 Mar 2003 16:46:21 +0100 (CET) Message-ID: <3E70A7D6.1060409@pydo.org> Date: Thu, 13 Mar 2003 16:46:30 +0100 From: Artur Pydo User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: fr-fr, fr, en-us, en MIME-Version: 1.0 To: freebsd-stable@freebsd.org Subject: Shifted ata raid drives display at boot. X-Enigmail-Version: 0.71.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-8.9 required=5.0 tests=AWL,USER_AGENT_MOZILLA_UA autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, I can see for a long time now shifted ata raid drives display at boot : {...] ar0: 38172MB [4866/255/63] status: READY subdisks: 0 READY ad4: 38172MB [77557/16/63] at ... 1 READY ad6: 38172MB [77557/16/63] at ... acd0: CD-RW at ata0-master UDMA33 [...] I expected : {...] ar0: 38172MB [4866/255/63] status: READY subdisks: 0 READY ad4: 38172MB [77557/16/63] at ... 1 READY ad6: 38172MB [77557/16/63] at ... acd0: CD-RW at ata0-master UDMA33 [...] While looking through the sys/dev/ata/ata-raid.c file i found : 219 for (disk = 0; disk < rdp->total_disks; disk++) { 220 if (rdp->disks[disk].flags & AR_DF_PRESENT) { 221 if (rdp->disks[disk].flags & AR_DF_ONLINE) 222 printf(" %d READY ", disk); 223 else if (rdp->disks[disk].flags & AR_DF_SPARE) 224 printf(" %d SPARE ", disk); 225 else 226 printf(" %d FREE ", disk); 227 ad_print(AD_SOFTC(rdp->disks[disk])); 228 printf(" "); 229 ata_enclosure_print(AD_SOFTC(rdp->disks[disk])->device); It seems that line 228 shifts the display of ata_enclosure information if it exists, but if it does not it shifts the display of the next displayed line. Probably, line 228 should be moved to ata_enclosure_print function instead. -- Best regards, Artur Pydo. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message