From owner-freebsd-geom@FreeBSD.ORG  Thu Dec 30 19:45:50 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 62C9B16A4CE
	for <geom@freebsd.org>; Thu, 30 Dec 2004 19:45:50 +0000 (GMT)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1B40743D2F
	for <geom@freebsd.org>; Thu, 30 Dec 2004 19:45:50 +0000 (GMT)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id E0DAA530C; Thu, 30 Dec 2004 20:45:48 +0100 (CET)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP id 7C29E5308;
	Thu, 30 Dec 2004 20:45:22 +0100 (CET)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 3DDCFB874; Thu, 30 Dec 2004 20:45:22 +0100 (CET)
To: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <47024.1104435560@critter.freebsd.dk>
From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
Date: Thu, 30 Dec 2004 20:45:22 +0100
In-Reply-To: <47024.1104435560@critter.freebsd.dk> (Poul-Henning Kamp's
 message of "Thu, 30 Dec 2004 20:39:20 +0100")
Message-ID: <xzpoegbvact.fsf@dwp.des.no>
User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=5.0 tests=AWL,FORGED_RCVD_HELO 
	autolearn=disabled version=3.0.1
cc: geom@freebsd.org
Subject: Re: GEOM_VOL panics when audio CD is present
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Dec 2004 19:45:50 -0000

"Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
> I think the right check is to make sure the sectorsize is a power
> of two && > DEV_BSIZE.

Not good enough.  The panic will still be triggered by providers with
a sector size larger than 8192 (which is the smallest non-zero offset
g_vol_ffs_taste() tries to use).  The fact that no such devices exist
today does not mean they won't exist at some point in the not-so-
distant future.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no