From owner-freebsd-bugs@FreeBSD.ORG  Sun Jun 22 17:40:03 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD5C61065671
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 22 Jun 2008 17:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C29D08FC21
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 22 Jun 2008 17:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5MHe3JN019157
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 22 Jun 2008 17:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5MHe3Sa019156;
	Sun, 22 Jun 2008 17:40:03 GMT (envelope-from gnats)
Date: Sun, 22 Jun 2008 17:40:03 GMT
Message-Id: <200806221740.m5MHe3Sa019156@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Gavin Atkinson <gavin@FreeBSD.org>
Cc: 
Subject: Re: kern/120714: [viapm] [patch] viapm driver doesn't work on VIA
 VT8237 chip
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Gavin Atkinson <gavin@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jun 2008 17:40:03 -0000

The following reply was made to PR kern/120714; it has been noted by GNATS.

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/120714: [viapm] [patch] viapm driver doesn't work on VIA
 VT8237 chip
Date: Sun, 22 Jun 2008 18:37:16 +0100 (BST)

 I don't really see any need to collapse the four similar chipsets into 
 one, here is a patch which simply adds support for the chip without 
 affecting the description of others.
 
 Index: src/sys/pci/viapm.c
 ===================================================================
 RCS file: /usr/ncvs/src/sys/pci/viapm.c,v
 retrieving revision 1.19
 diff -u -r1.19 viapm.c
 --- src/sys/pci/viapm.c	6 Jun 2008 18:29:56 -0000	1.19
 +++ src/sys/pci/viapm.c	22 Jun 2008 17:33:17 -0000
 @@ -70,6 +70,7 @@
   #define VIA_8233_PMU_ID		0x30741106
   #define	VIA_8233A_PMU_ID	0x31471106
   #define	VIA_8235_PMU_ID		0x31771106
 +#define	VIA_8237_PMU_ID		0x32271106
   #define	VIA_CX700_PMU_ID	0x83241106
 
   #define VIAPM_INB(port) \
 @@ -285,6 +286,12 @@
   		base_cfgreg = VIAPM_8233_BASE;
   		goto viapro;
 
 +	case VIA_8237_PMU_ID:
 +		desc = "VIA VT8237 Power Management Unit";
 +		viapm->type = VIAPM_TYP_UNKNOWN;
 +		base_cfgreg = VIAPM_8233_BASE;
 +		goto viapro;
 +
   	case VIA_CX700_PMU_ID:
   		desc = "VIA CX700 Power Management Unit";
   		viapm->type = VIAPM_TYP_UNKNOWN;