From owner-svn-src-all@FreeBSD.ORG  Tue Mar 31 14:30:47 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50FD31065722;
	Tue, 31 Mar 2009 14:30:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 3FE2C8FC2E;
	Tue, 31 Mar 2009 14:30:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n2VEUlcG002557;
	Tue, 31 Mar 2009 14:30:47 GMT (envelope-from jhb@svn.freebsd.org)
Received: (from jhb@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n2VEUlSG002556;
	Tue, 31 Mar 2009 14:30:47 GMT (envelope-from jhb@svn.freebsd.org)
Message-Id: <200903311430.n2VEUlSG002556@svn.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 31 Mar 2009 14:30:47 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r190593 - head/lib/libstand
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2009 14:30:47 -0000

Author: jhb
Date: Tue Mar 31 14:30:46 2009
New Revision: 190593
URL: http://svn.freebsd.org/changeset/base/190593

Log:
  Fix an off-by-one buffer overflow in ngets().
  
  Submitted by:	Bruce Can
  MFC after:	1 month

Modified:
  head/lib/libstand/gets.c

Modified: head/lib/libstand/gets.c
==============================================================================
--- head/lib/libstand/gets.c	Tue Mar 31 12:51:49 2009	(r190592)
+++ head/lib/libstand/gets.c	Tue Mar 31 14:30:46 2009	(r190593)
@@ -74,7 +74,7 @@ ngets(char *buf, int n)
 	    putchar('\n');
 	    break;
 	default:
-	    if ((n < 1) || ((lp - buf) < n)) {
+	    if ((n < 1) || ((lp - buf) < n - 1)) {
 		*lp++ = c;
 		putchar(c);
 	    }