From owner-svn-src-head@freebsd.org  Wed Apr 26 21:51:19 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3AB6D51B11;
 Wed, 26 Apr 2017 21:51:18 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D5F8692;
 Wed, 26 Apr 2017 21:51:18 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3QLpFVD068594;
 Wed, 26 Apr 2017 14:51:15 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3QLpEMX068593;
 Wed, 26 Apr 2017 14:51:14 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201704262151.v3QLpEMX068593@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r317409 - head/contrib/tcpdump
In-Reply-To: <20170426212305.GF56922@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Date: Wed, 26 Apr 2017 14:51:14 -0700 (PDT)
CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, 
 svn-src-head@FreeBSD.org
Reply-To: rgrimes@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2017 21:51:19 -0000

>   Rodney,
> 
> On Tue, Apr 25, 2017 at 11:30:17AM -0700, Rodney W. Grimes wrote:
> R> > Author: glebius
> R> > Date: Tue Apr 25 15:56:46 2017
> R> > New Revision: 317409
> R> > URL: https://svnweb.freebsd.org/changeset/base/317409
> R> > 
> R> > Log:
> R> >   Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after free
> R> 
> R> Lets not use git hashes as references in commit messages,
> R> it has very little value for someone reading a log of changes
> R> looking for something.  There is no promise that it can be
> R> found later (github can go Poof).
> 
> Since I did previous import of tcpdump, I find it very useful to
> see what exactly has been cherry-picked forward, for the person
> who will do next import, be it me or someone else.
> 
> I agree that I should have put the hash into "meta data portion
> of commit message", not in the description. I will do so next time.

Thank you!  Thats really all I wanted

-- 
Rod Grimes                                                 rgrimes@freebsd.org