From owner-freebsd-current@freebsd.org Fri Jul 22 01:46:34 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6B98BA098D for ; Fri, 22 Jul 2016 01:46:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com [IPv6:2607:f8b0:400e:c03::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 876BB1CC1 for ; Fri, 22 Jul 2016 01:46:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-pa0-x244.google.com with SMTP id ez1so6065875pab.3 for ; Thu, 21 Jul 2016 18:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DSSyZ4t7tyUuc2V1MgWVocKTF4QojViBJvcWSNqVskI=; b=klJ0PMI/sQDJRdmwuME7nOglIGZs6M7qqHI2s6JTb7HqqHpqsa0lLdr/1pb6GiLiNx kc4UQPWHP4MeBGfni46bwDM0/tFxjgxrez8cdF4PO29VqJfxzfPp451XYH8wSUQ6tUfW KbgHRGsTHbcelTfaNzmzLawHgz8vc6eRUCUrEv+kehf1uYtPyExcjO67YJdt1OnHPvF5 PC5mkCca/1atVT5mXI73fPzihNUMaHHS9yBySLP+95U33JlTPq3s11gQ3s+6N314rhOp NiVpPyZHECZK+ym/ixvK4RE8yXSiAjkkq/6pEqB/UVp3frRt/sgNtrcSCZdbve3oIVMv X9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DSSyZ4t7tyUuc2V1MgWVocKTF4QojViBJvcWSNqVskI=; b=IQlXWKvBRWWJYCo7ud2FADpwhlX4BmDvS2I3t1VBdeRFBhYore1EyKX7Sw6QoKGg1C SiBNLa46/NZV6F+EqUUsp+DXCCea8rb/0+3mKsHQGizdibrsolsdwBpfXS1h957WEJC8 XBYZVeA+6nxmC4KPVjcUKceDFy3evWRLx/YECNGGZHgiOX6FRny0oaUOAlRdGSx4cqLE Unp0VnQnP9IreuCkezCd7I00+EneSdN/MwAaM7lf1DLb4ATZnuP6+SRHirqUKEw1ylxR cPHkzAjsyvXX8na3Tl2T878nhedH++mGjavqtq+5QuS4c6nDVcHrs/sX5HqzA9zYAaUp ayXg== X-Gm-Message-State: AEkoouv7U+KC0vw8UxcDDe42vaiY7zgUqiHBAXg4zhLGE6hEBXjz3iIcNeiRmgs/SiKpsA== X-Received: by 10.66.232.136 with SMTP id to8mr2096333pac.130.1469151994000; Thu, 21 Jul 2016 18:46:34 -0700 (PDT) Received: from [100.127.64.186] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id g10sm15133791pfc.57.2016.07.21.18.46.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jul 2016 18:46:33 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: kernel no longer builds without nvme From: Warner Losh In-Reply-To: <4FF3E583-1B86-4F98-B591-A4DE6570B394@gmail.com> Date: Thu, 21 Jul 2016 19:46:31 -0600 Cc: Michael Butler , freebsd-current , Scott Long , Warner Losh Content-Transfer-Encoding: quoted-printable Message-Id: References: <8b4650e7-81b1-be1e-0de5-dc94a32801c4@protected-networks.net> <4FF3E583-1B86-4F98-B591-A4DE6570B394@gmail.com> To: "Ngie Cooper (yaneurabeya)" X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Fri, 22 Jul 2016 02:07:22 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 01:46:34 -0000 > On Jul 21, 2016, at 11:53 AM, Ngie Cooper (yaneurabeya) = wrote: >=20 >>=20 >> On Jul 21, 2016, at 06:45, Michael Butler = wrote: >>=20 >> For those of us who build "minimal" kernels: >>=20 >> Building /usr/obj/usr/src/sys/VM02/vers.c >> Building /usr/obj/usr/src/sys/VM02/vers.o >> Building /usr/obj/usr/src/sys/VM02/kernel >> --- kernel --- >> linking kernel >> cam_xpt.o: In function `xpt_announce_periph': >> /usr/src/sys/cam/cam_xpt.c:(.text+0xcd2): undefined reference to >> `nvme_print_ident' >> cam_xpt.o: In function `xpt_denounce_periph': >> /usr/src/sys/cam/cam_xpt.c:(.text+0xe76): undefined reference to >> `nvme_print_ident' >> cam_xpt.o: In function `xpt_run_devq': >> /usr/src/sys/cam/cam_xpt.c:(.text+0x2bc0): undefined reference to >> `nvme_op_string' >> /usr/src/sys/cam/cam_xpt.c:(.text+0x2bd8): undefined reference to >> `nvme_cmd_string' >> cam_xpt.o: In function `xpt_bus_register': >> /usr/src/sys/cam/cam_xpt.c:(.text+0x620b): undefined reference to >> `nvme_get_xport' >> *** [kernel] Error code 1 >=20 > CCing Scott and Warner. This is one of many reports I=E2=80=99ve seen = related to this issue. Fixed in https://svnweb.freebsd.org/changeset/base/303165 . Sorry about = the mixup. I didn=E2=80=99t even think to test this case. Warner