From nobody Mon Aug 28 03:34:19 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RYx4n58Hdz4ql6L for ; Mon, 28 Aug 2023 03:34:33 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [66.165.241.226]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RYx4m0YTJz4K08 for ; Mon, 28 Aug 2023 03:34:32 +0000 (UTC) (envelope-from pete@nomadlogic.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=nomadlogic.org header.s=04242021 header.b=TWC0JWYY; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 66.165.241.226 as permitted sender) smtp.mailfrom=pete@nomadlogic.org; dmarc=pass (policy=quarantine) header.from=nomadlogic.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nomadlogic.org; s=04242021; t=1693193663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=NGamnXS9XLj4N15GMY2G5iqxQ7oqNidnMAYrzqQpYTs=; b=TWC0JWYYXwmHT6bwFTLskF8gdRiL1X6WjfSjFJuMJvMjksg5RCGyTyXsQnGR52ik4ZFfQ2 g6YFQOVYjCI9/D4qWslXclFVxvyqrEIMgc/LsRCNUgY7JWTC3UoYGBN4/jbXYAALwUyjXK z/Y/ESozQ1Rtcpnesh7Ew1lCNR1CHXM= Received: from topanga (cpe-24-24-168-214.socal.res.rr.com [24.24.168.214]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 6baa53cf (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 28 Aug 2023 03:34:22 +0000 (UTC) Date: Sun, 27 Aug 2023 20:34:19 -0700 From: Pete Wright To: freebsd-current@freebsd.org Subject: zfs autotrim default to off now Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[nomadlogic.org,quarantine]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[nomadlogic.org:s=04242021]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:29802, ipnet:66.165.240.0/22, country:US]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[nomadlogic.org:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCVD_TLS_ALL(0.00)[] X-Spamd-Bar: --- X-Rspamd-Queue-Id: 4RYx4m0YTJz4K08 looking at a recent pull of CURRENT i'm noticing this in the git logs: #15079 set autotrim default to 'off' everywhere which references this openzfs PR: https://github.com/openzfs/zfs/pull/15079 looking at the PR i'm not seeing a reference to a bug report or anything, is anyone able to point me to a bug report for this. it seems like a pretty major issue: "As it turns out having autotrim default to 'on' on FreeBSD never really worked due to mess with defines where userland and kernel module were getting different default values (userland was defaulting to 'off', module was thinking it's 'on')." i'd just like to make sure i better understand the issue and can see if my systems are impacted. thanks! -pete -- Pete Wright pete@nomadlogic.org