From owner-svn-doc-all@FreeBSD.ORG Thu Feb 14 17:08:41 2013 Return-Path: Delivered-To: svn-doc-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 1B0ADB5A for ; Thu, 14 Feb 2013 17:08:41 +0000 (UTC) (envelope-from ale@FreeBSD.org) Received: from andxor.it (relay.andxor.it [195.223.2.3]) by mx1.freebsd.org (Postfix) with SMTP id 43CAFFDB for ; Thu, 14 Feb 2013 17:08:39 +0000 (UTC) Received: (qmail 12271 invoked from network); 14 Feb 2013 17:08:39 -0000 Received: from unknown (HELO alex.andxor.it) (192.168.2.30) by andxor.it with SMTP; 14 Feb 2013 17:08:39 -0000 Message-ID: <511D1A16.6040505@FreeBSD.org> Date: Thu, 14 Feb 2013 18:08:38 +0100 From: Alex Dupre User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r40970 - head/en_US.ISO8859-1/books/porters-handbook References: <201302141435.r1EEZsXu042558@svn.freebsd.org> <511CF790.7040804@FreeBSD.org> <511D0D48.1090000@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.5.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org, Pietro Cerutti X-BeenThere: svn-doc-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire doc trees \(except for " user" , " projects" , and " translations" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2013 17:08:41 -0000 Eitan Adler ha scritto: > Every time the -pthread vs -lpthread discussion comes up this is brought up. > I have no idea why this is, or who committed it. marcus and kris changed that lines a few times in the past, but PTHREAD_CFLAGS never contained -pthread. The reason is that such variable was intended for FreeBSD and no preprocessor flag is needed since FreeBSD 5. > -pthread also defines certain preproccessor flags and may link in > additional libraries. Yes, it could define other flags and it could link other libraries, but actually it doesn't do it. > Perhaps if one is changing other things it doesn't hurt to also fix > this. It isn't a big priority though. I agree with you that using -pthread on compiling and linking is The Right Thing. My objection is that the porter's handbook says maintainers *must* patch ports to use -pthread. When PTHREAD_CFLAGS/LIBS were added to bsd.port.mk (and such requirements added to porter's handbook) there was a specific actual reason and we should obey. Now there isn't anymore, we can finally live happy and stop patching ports. A more useful addition in the Porter's handbook IMHO would be an entry about 'ltverhack' to avoid useless shared library bumps. Even this is not mandatory, but at least we get a huge gain. -- Alex Dupre