From owner-cvs-src@FreeBSD.ORG Sat Jul 15 09:23:29 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97DC116A4DA; Sat, 15 Jul 2006 09:23:29 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CD5343D46; Sat, 15 Jul 2006 09:23:29 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 94B6446D50; Sat, 15 Jul 2006 05:23:28 -0400 (EDT) Date: Sat, 15 Jul 2006 10:23:28 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alfred Perlstein In-Reply-To: <20060714193538.GN25976@elvis.mu.org> Message-ID: <20060715102243.X61840@fledge.watson.org> References: <200607081406.k68E6u3w049339@repoman.freebsd.org> <20060714193538.GN25976@elvis.mu.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/pseudofs pseudofs_vnops.c src/sys/compat/linux linux_misc.c src/sys/compat/linprocfs linprocfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2006 09:23:29 -0000 On Fri, 14 Jul 2006, Alfred Perlstein wrote: > Could the KASSERT here be changed to a warning log message instead? > > I don't like the idea of kernel modules failing catastrophically > when they could fail gracefully by just emitting an error. > > Is that OK? > > + KASSERT(kp.ki_stat <= sizeof(linux_state), > + ("linprocfs: don't know how to handle unknown FreeBSD state")); Or, if this is really just a structure size thing, we should pick it up at compile-time with CTASSERT? Robert N M Watson Computer Laboratory University of Cambridge > > -Alfred > > * Alexander Leidinger [060708 07:06] wrote: >> netchild 2006-07-08 14:06:56 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_6) >> sys/fs/pseudofs pseudofs_vnops.c >> sys/compat/linux linux_misc.c >> sys/compat/linprocfs linprocfs.c >> Log: >> MFC: >> - linux_misc.c 1.179 >> Don't copyout/do unneccesary work if the buffer is a NULL pointer. >> >> Noticed by: Dmitry Ganenko >> Reviewed by: rdivacky (the original version as in emulation@) >> >> - linprocfs.c 1.96: >> Improve linprovfs to provide/fix the >> - process state (idle, sleeping, running, ...) [1] >> - the process group ID of the process which owns the connected tty >> - some page fault stats >> - time spend in kernel/userland >> - priority/nice value >> - starttime [1] >> - memory/swap stats >> - scheduling policy >> >> Additionally add some new fields and correct some not filled out ones. >> >> This brings us down to 15 dummy fields. >> >> The fields marked with [1] are needed to get Oracle 10 running. The starttime >> field is not completely right, since it displays the _same_ starttime for >> _every_ process, but at least it is not 0 and Oracle accepts this. >> >> Noticed by: Dmitry Ganenko [1] >> Reviewed by: des, rdivacky >> >> - pseudofs_vnops.c 1.60: >> Correctly calculate a buffer length. It was off by one so a read() returned >> one byte less than needed. >> >> Noticed by: Dmitry Ganenko >> Testcase by: Dmitry Ganenko >> Reviewed by: des >> Submitted by: rdivacky >> Sponsored by: Google SoC 2006 >> >> All of those are needed for Oracle 10. Since previous Oracle versions work >> just fine without those fixes, these patches can be seen as regression fixes >> too. Because of this I think they are a RELENG_6_x candidate (MFC reminder >> set). >> >> MFC after: 1 month >> >> Revision Changes Path >> 1.89.2.4 +51 -27 src/sys/compat/linprocfs/linprocfs.c >> 1.170.2.1 +13 -11 src/sys/compat/linux/linux_misc.c >> 1.56.2.4 +1 -1 src/sys/fs/pseudofs/pseudofs_vnops.c > > -- > - Alfred Perlstein > - coder / sysadmin / FreeBSD Hacker / All that jazz - >