From owner-freebsd-arch@FreeBSD.ORG Mon May 4 09:51:22 2015 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 47137389; Mon, 4 May 2015 09:51:22 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2B8A182D; Mon, 4 May 2015 09:51:21 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t449pGGD009361 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 4 May 2015 12:51:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t449pGGD009361 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t449pGhP009360; Mon, 4 May 2015 12:51:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 4 May 2015 12:51:16 +0300 From: Konstantin Belousov To: Gleb Smirnoff Cc: alc@FreeBSD.org, arch@FreeBSD.org Subject: Re: more strict KPI for vm_pager_get_pages() Message-ID: <20150504095116.GF2390@kib.kiev.ua> References: <20150430142408.GS546@nginx.com> <20150504082426.GC2390@kib.kiev.ua> <20150504091137.GH34544@glebius.int.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504091137.GH34544@glebius.int.ru> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 09:51:22 -0000 On Mon, May 04, 2015 at 12:11:37PM +0300, Gleb Smirnoff wrote: > On Mon, May 04, 2015 at 11:24:26AM +0300, Konstantin Belousov wrote: > K> Below is the summary of my part of the internal discussion about the changes. > > Quite short. Is it truncated? No. IMO, I pointed out the most important point about the patch. If other changes in the patch are unrelated, they must be extracted and discussed (and committed) separately. Due to the fundamental nature of the code being changed, the extra work to make it easier to bisect and detect regressions worth it. > -- > Totus tuus, Glebius. > > K> Traditionally, Unix allows the filesystems to perform the short reads. > K> Most fundamental change in the patch removes this freedom from the > K> filesystem implementation, and I think that only local filesystems could > K> be compliant with the proposed strictness. > K> > K> IMO, the response from vm_pager_haspages() is only advisory, since > K> filesystem might not control the external entities which are the source > K> of the required data. > > That's why remote filesystems use vop_stdbmap() (or similar), which > always return zeroes for "after" and "before" hints. Which precludes useful optimizations, at all, in the future.