From owner-cvs-all Wed Mar 1 0:24:22 2000 Delivered-To: cvs-all@freebsd.org Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by hub.freebsd.org (Postfix) with ESMTP id 618BE37BE0E; Wed, 1 Mar 2000 00:24:08 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id SAA93690; Wed, 1 Mar 2000 18:53:24 +1030 (CST) Date: Wed, 1 Mar 2000 18:53:24 +1030 From: Greg Lehey To: Peter Wemm Cc: Bernd Walter , Alfred Perlstein , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bernd Walter Subject: Re: cvs commit: src/sys/dev/vinum vinumrequest.c Message-ID: <20000301185324.J87829@freebie.lemis.com> References: <20000301030042.125021CE2@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <20000301030042.125021CE2@overcee.netplex.com.au> WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Wednesday, 1 March 2000 at 11:00:42 +0800, Peter Wemm wrote: > Bernd Walter wrote: >> On Tue, Feb 29, 2000 at 01:17:37AM -0800, Alfred Perlstein wrote: >>> * Greg Lehey [000229 00:37] wrote: >>>> On Tuesday, 29 February 2000 at 0:25:00 -0800, Alfred Perlstein wrote: >>>>> * Greg Lehey [000228 22:45] wrote: >>>> The trouble is, you and Bernd keep asking for opposite things, and I >>>> was getting out of phase on the whole matter. In any case, another >>>> change I made (MAXREQUESTS = 30000) means that we'll never call tsleep >>>> here. >>> >>> The point is that PCATCH never works here, and that there shouldn't >>> be landminds in the code, if someone where to reduce MAXREQUESTS >>> to test something they'd have a good chance of getting hit. >> >> It never worked here too. >> But what do you want? Greg already removed it: >> bash-2.03$ cd /var/d7/src-2000-02-12/src/sys/dev/vinum >> bash-2.03$ grep PCATCH * >> vinumconfig.c: if ((error = tsleep(&vinum_conf, PRIBIO | PCATCH, "vincfg", 0 > )) != 0) > > Data point, after a cvsup 5 minutes ago: > > peter@overcee[10:59am]~src/sys/dev/vinum-290> cvs -q up -A > peter@overcee[10:59am]~src/sys/dev/vinum-291> grep PCATCH * > vinumconfig.c: if ((error = tsleep(&vinum_conf, PRIBIO | PCATCH, "vincfg", 0)) != 0) > vinumrequest.c: tsleep(&launch_requests, PRIBIO | PCATCH, "vinbuf", 0); /* wait for it to subside */ > > It's still there. It was. I've removed the entire tsleep call and the throttling that went with it. This may improve performance. Greg -- For more information, see http://www.lemis.com/email.html Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message