From owner-cvs-all Tue Jan 15 9:28:45 2002 Delivered-To: cvs-all@freebsd.org Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 80C2137B41A; Tue, 15 Jan 2002 09:28:24 -0800 (PST) Received: (from rizzo@localhost) by iguana.icir.org (8.11.3/8.11.3) id g0FHSOO78344; Tue, 15 Jan 2002 09:28:24 -0800 (PST) (envelope-from rizzo) Date: Tue, 15 Jan 2002 09:28:24 -0800 From: Luigi Rizzo To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/natd natd.c Message-ID: <20020115092824.B75791@iguana.icir.org> References: <200201151707.g0FH7uB73802@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201151707.g0FH7uB73802@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jan 15, 2002 at 09:07:56AM -0800, Ruslan Ermilov wrote: > ru 2002/01/15 09:07:56 PST > > Modified files: > sbin/natd natd.c > Log: > Back out part of the revision 1.2 changes -- sendto(2) can > not return ENOBUFS for unreliable protocols like divert. actually sendto does return ENOBUFS, it's just select() which cannot be used to check for writability on such sockets. > This should fix an issue when natd(8) keeps spamming already > full dummynet(4) queues with the same packet forever. not just dummynet, this applies to _any_ device-level queue, including ethernet, ppp and serial lines. > Spotted by: chkno@dork.com > Explained by: luigi probably not well enough given the commit message :) (just kidding... thanks to Ruslan for fixing this!) cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message