From owner-svn-src-head@freebsd.org Sun Jun 3 10:04:50 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2CB6CFDF1D2; Sun, 3 Jun 2018 10:04:50 +0000 (UTC) (envelope-from Michael.Tuexen@macmic.franken.de) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A880E7C50D; Sun, 3 Jun 2018 10:04:49 +0000 (UTC) (envelope-from Michael.Tuexen@macmic.franken.de) Received: from [10.54.165.156] (unknown [88.128.80.153]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 6234C72106C13; Sun, 3 Jun 2018 12:04:46 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r334554 - head/usr.bin/top From: Michael Tuexen In-Reply-To: <201806030602.w5362VuJ066716@repo.freebsd.org> Date: Sun, 3 Jun 2018 12:04:45 +0200 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <780B5AE9-CB7E-4668-9BF2-4E6FC62DD2E3@macmic.franken.de> References: <201806030602.w5362VuJ066716@repo.freebsd.org> To: Eitan Adler X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 10:04:50 -0000 top doesn't work on a amd64 (64 logical cores) and on an arm64 (8 cores) system anymore (world and kernel are in sync): tuexen@epyc:~ % uname -a FreeBSD epyc.nplab.de 12.0-CURRENT FreeBSD 12.0-CURRENT #5 r334554: Sun = Jun 3 11:26:58 CEST 2018 = root@epyc.nplab.de:/usr/obj/usr/home/tuexen/head/amd64.amd64/sys/GENERIC = amd64 tuexen@epyc:~ % top top: sysctlbyname kern.cp_times: Cannot allocate memory FreeBSD bsd14.fh-muenster.de 12.0-CURRENT FreeBSD 12.0-CURRENT #16 = r334554: Sun Jun 3 11:47:38 CEST 2018 = root@bsd14.fh-muenster.de:/usr/obj/usr/home/tuexen/head/arm64.aarch64/sys/= GENERIC arm64 tuexen@bsd14:~ % top top: sysctlbyname kern.cp_times: Cannot allocate memory Best regards Michael > On 3. Jun 2018, at 08:02, Eitan Adler wrote: >=20 > Author: eadler > Date: Sun Jun 3 06:02:31 2018 > New Revision: 334554 > URL: https://svnweb.freebsd.org/changeset/base/334554 >=20 > Log: > top(1): Only use NO_WERROR for base gcc >=20 > This is what was intended. If statements are hard. >=20 > Modified: > head/usr.bin/top/Makefile >=20 > Modified: head/usr.bin/top/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/usr.bin/top/Makefile Sun Jun 3 05:20:11 2018 = (r334553) > +++ head/usr.bin/top/Makefile Sun Jun 3 06:02:31 2018 = (r334554) > @@ -10,11 +10,13 @@ MAN=3D top.1 >=20 > WARNS?=3D 6 >=20 > -.if ${COMPILER_TYPE} =3D=3D "gcc" && ${COMPILER_VERSION} >=3D 50000 > +.if ${COMPILER_TYPE} =3D=3D "gcc" > +.if ${COMPILER_VERSION} >=3D 50000 > CFLAGS.gcc=3D-Wno-error=3Dcast-align -Wno-error=3Dcast-qual = -Wno-error=3Ddiscarded-qualifiers -Wno-error=3Dincompatible-pointer-types = \ > -Wno-error=3Dmaybe-uninitialized > .else #base gcc > NO_WERROR=3D > +.endif > .endif > CFLAGS.clang=3D-Wno-error=3Dincompatible-pointer-types-discards-qualifie= rs -Wno-error=3Dcast-qual -Wno-error=3Dcast-align >=20 >=20