From owner-freebsd-current@freebsd.org Sat Jan 30 17:12:54 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7547A73398 for ; Sat, 30 Jan 2016 17:12:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 79E4CF22 for ; Sat, 30 Jan 2016 17:12:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-oi0-x22c.google.com with SMTP id r14so65915071oie.0 for ; Sat, 30 Jan 2016 09:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vheAFNoNwz+FJTgNVTiya85RmkBeaZEUVYztxX42gmc=; b=pPWIPzIaU2APJAkGGEKTjfTdNuf6aX/GhsEA49g08vornG9JVYGsv4yWAg9pzGwiVE lxXcvPiMFad5ujWr7HI1RpBs/WnUgiPQPHSZWUsyA2WAHWBv7QevK6Eb/f0QdiCkd8sO b+Xd+B3SCu8iJnsiO6bezV+jFDzej6fatmQbZrzu0agaPYEd5AAGNJME02DJVNz41zIV WxHDYNGC/rUTR1EO+BMzUd0ij8Ad2touZdQYSmPQoCHfUp5ACXUwa2/XzNCTSHv2K0zY VyARIYRTdz4SxKDtG8PaZCwU9Fd3oN2dtc+Rc5ba/lhIlO2Lb3eG2RZhaDhKSqBOwikp GhQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=vheAFNoNwz+FJTgNVTiya85RmkBeaZEUVYztxX42gmc=; b=aiDhzi/UzKwTa/uldglgquilNWOEeZfJ0CIE2ik0G6cQxk/AJU26rlZnI1urfFfW/N +98FgcSjR3wEwiOblxx2ajTtPf6eMVKfaKTUnb/HDx+trMIUghWbToUbk01cWG98SiQw iIVaNAMLFh2iaYYBp53bFd+W1dH4ZjHncnyydeJGYN421fDv1sHTZn98G+NP4LZwWpwL QHDl8uSTMTVfynTd1bBZl53cH1sEtSJ+D8IlutkGTOrPunQIwXRYSEyd7KgHiHRUthzQ nqXm6EShf3J1rhYoArBcF2pk4LEldij7CSNYoN4VAF5gDL7AVYak52zagzycXOExuKcV 3IQg== X-Gm-Message-State: AG10YORDAxv9kgXj8xMFqE7ZPHcKZBTUPZZNsYa3IYt6HCtSJZPkqnAaq1QOHNfPVlwk7w== X-Received: by 10.202.209.3 with SMTP id i3mr1893665oig.122.1454173973601; Sat, 30 Jan 2016 09:12:53 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:c5f3:3c2a:d3ee:c0d7? ([2601:601:800:126d:c5f3:3c2a:d3ee:c0d7]) by smtp.gmail.com with ESMTPSA id q10sm2985649obg.1.2016.01.30.09.12.50 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Jan 2016 09:12:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: CURRENT: buildworld failure due to nvmecontrol source error From: NGie Cooper In-Reply-To: Date: Sat, 30 Jan 2016 09:12:49 -0800 Cc: "O. Hartmann" , FreeBSD CURRENT Content-Transfer-Encoding: quoted-printable Message-Id: <8977554C-9BF9-4D66-AFBC-5BAEFCD58704@gmail.com> References: <20160130123907.6844f551.ohartman@zedat.fu-berlin.de> To: Outback Dingo X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 17:12:54 -0000 > On Jan 30, 2016, at 04:10, Outback Dingo = wrote: >=20 > On Sat, Jan 30, 2016 at 12:39 PM, O. Hartmann = > wrote: >=20 >> Buildworld (r295070) fails in building nvmecontrol patches correctly: >>=20 >> [...] >> (cd /usr/src/lib/libc/tests/gen && DEPENDFILE=3D.depend.raise_test >> NO_SUBDIR=3D1 make >> -f /usr/src/lib/libc/tests/gen/Makefile _RECURSING_PROGS=3Dt >> PROG=3Draise_test ) --- >> all_subdir_share --- =3D=3D=3D> share/i18n/csmapper/APPLE (all) >> --- all_subdir_usr.sbin --- >> =3D=3D=3D> usr.sbin/acpi/iasl (all) >> --- all_subdir_sbin --- >> /usr/src/sbin/nvmecontrol/power.c:44:16: error: invalid application = of >> 'sizeof' to an >> incomplete type 'struct nvme_power_state' = _Static_assert(sizeof(struct >> nvme_power_state) >> =3D=3D 256 / NBBY, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ >> /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of >> 'struct >> nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D= 256 / >> NBBY, >> ^ >> /usr/src/sbin/nvmecontrol/power.c:60:14: error: incomplete definition = of >> type 'struct >> nvme_power_state' mpower =3D nps->mp; >> ~~~^ >> /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of >> 'struct >> nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D= 256 / >> NBBY, >> ^ >> /usr/src/sbin/nvmecontrol/power.c:61:9: error: incomplete definition = of >> type 'struct >> nvme_power_state' if (nps->mps =3D=3D 0) >=20 > same here to confirm > cc -pg -O2 -pipe > = -I/backup/freebsd/kerberos5/lib/libroken/../../../crypto/heimdal/lib/roken= > -I. -DHAVE_CONFIG_H > -I/backup/freebsd/kerberos5/lib/libroken/../../include -std=3Dgnu99 = -fstack > -protector-strong -Qunused-arguments -c > = /backup/freebsd/kerberos5/lib/libroken/../../../crypto/heimdal/lib/roken/e= read.c > -o eread.po > --- all_subdir_secure --- > cc -pg -O2 -pipe > -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl = -DTERMIOS > -DANSI_SOURCE -DOPENSSL_THREADS -DDSO_DLFCN -DHAVE_DLFCN_H -DL_ENDIAN > -DOPENSSL_IA32_SSE2 -DAES > _ASM -DBSAES_ASM -DVPAES_ASM -DECP_NISTZ256_ASM -DOPENSSL_BN_ASM_MONT > -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DMD5_ASM -DGHASH_ASM > -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DWHIRLPOOL_ASM > -I/usr/obj/backup/freebsd/secure/lib/libcrypto > -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/a > sn1 > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/evp > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/mode= s > -std=3Dgnu89 -fstack-protector-strong > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int > -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conve > rsion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum > -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c > /backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl > /crypto/evp/m_md5.c -o m_md5.po > --- all_subdir_sbin --- > /backup/freebsd/sbin/nvmecontrol/power.c:44:16: error: invalid = application > of 'sizeof' to an incomplete type 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:60:14: error: incomplete > definition of type 'struct nvme_power_state' > mpower =3D nps->mp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:61:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->mps =3D=3D 0) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:63:14: error: incomplete > definition of type 'struct nvme_power_state' > ipower =3D nps->idlp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:64:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->ips =3D=3D 1) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:66:14: error: incomplete > definition of type 'struct nvme_power_state' > --- all_subdir_rescue --- > --- dhclient_make --- > --- packet.o --- > --- all_subdir_sbin --- > apower =3D nps->actp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:67:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->aps =3D=3D 1) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:35: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:54: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:31: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:50: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:60: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:73:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->rwt, nps->rwl, ipower / 10000, ipower % 10000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:73:22: error: incomplete > definition of type 'struct nvme_power_state' > nps->rwt, nps->rwl, ipower / 10000, ipower % 10000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:74:44: error: incomplete > definition of type 'struct nvme_power_state' > apower / 10000, apower % 10000, nps->apw); > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:86:29: error: no member named > 'power_state' in 'struct nvme_controller_data' > power_list_one(i, &cdata->power_state[i]); > ~~~~~ ^ > --- all_subdir_rescue --- > cc -O2 -pipe -DRESCUE -std=3Dgnu99 -fstack-protector-strong > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-un > used-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion > -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -W > no-knr-promoted-parameter -Qunused-arguments -c > /backup/freebsd/sbin/dhclient/packet.c -o packet.o > --- all_subdir_sbin --- > 18 errors generated. > *** [power.o] Error code 1 >=20 > make[4]: stopped in /backup/freebsd/sbin/nvmecontrol Hi, Thank you for the report. I=E2=80=99ve reverted the commit in = r295076, because it broke buildworld and the missing code wasn=E2=80=99t = apparent based on the commit done to nvmecontrol(8). Thanks! -NGie=