Date: Sat, 30 Jan 2016 09:12:49 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Outback Dingo <outbackdingo@gmail.com> Cc: "O. Hartmann" <ohartman@zedat.fu-berlin.de>, FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: CURRENT: buildworld failure due to nvmecontrol source error Message-ID: <8977554C-9BF9-4D66-AFBC-5BAEFCD58704@gmail.com> In-Reply-To: <CAKYr3zzt3KPF8iWKK8y7ZruxHe4BZNKV%2BH6LLYZtRc50tS2aZg@mail.gmail.com> References: <20160130123907.6844f551.ohartman@zedat.fu-berlin.de> <CAKYr3zzt3KPF8iWKK8y7ZruxHe4BZNKV%2BH6LLYZtRc50tS2aZg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 30, 2016, at 04:10, Outback Dingo <outbackdingo@gmail.com> = wrote: >=20 > On Sat, Jan 30, 2016 at 12:39 PM, O. Hartmann = <ohartman@zedat.fu-berlin.de> > wrote: >=20 >> Buildworld (r295070) fails in building nvmecontrol patches correctly: >>=20 >> [...] >> (cd /usr/src/lib/libc/tests/gen && DEPENDFILE=3D.depend.raise_test >> NO_SUBDIR=3D1 make >> -f /usr/src/lib/libc/tests/gen/Makefile _RECURSING_PROGS=3Dt >> PROG=3Draise_test ) --- >> all_subdir_share --- =3D=3D=3D> share/i18n/csmapper/APPLE (all) >> --- all_subdir_usr.sbin --- >> =3D=3D=3D> usr.sbin/acpi/iasl (all) >> --- all_subdir_sbin --- >> /usr/src/sbin/nvmecontrol/power.c:44:16: error: invalid application = of >> 'sizeof' to an >> incomplete type 'struct nvme_power_state' = _Static_assert(sizeof(struct >> nvme_power_state) >> =3D=3D 256 / NBBY, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ >> /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of >> 'struct >> nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D= 256 / >> NBBY, >> ^ >> /usr/src/sbin/nvmecontrol/power.c:60:14: error: incomplete definition = of >> type 'struct >> nvme_power_state' mpower =3D nps->mp; >> ~~~^ >> /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of >> 'struct >> nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D= 256 / >> NBBY, >> ^ >> /usr/src/sbin/nvmecontrol/power.c:61:9: error: incomplete definition = of >> type 'struct >> nvme_power_state' if (nps->mps =3D=3D 0) >=20 > same here to confirm > cc -pg -O2 -pipe > = -I/backup/freebsd/kerberos5/lib/libroken/../../../crypto/heimdal/lib/roken= > -I. -DHAVE_CONFIG_H > -I/backup/freebsd/kerberos5/lib/libroken/../../include -std=3Dgnu99 = -fstack > -protector-strong -Qunused-arguments -c > = /backup/freebsd/kerberos5/lib/libroken/../../../crypto/heimdal/lib/roken/e= read.c > -o eread.po > --- all_subdir_secure --- > cc -pg -O2 -pipe > -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl = -DTERMIOS > -DANSI_SOURCE -DOPENSSL_THREADS -DDSO_DLFCN -DHAVE_DLFCN_H -DL_ENDIAN > -DOPENSSL_IA32_SSE2 -DAES > _ASM -DBSAES_ASM -DVPAES_ASM -DECP_NISTZ256_ASM -DOPENSSL_BN_ASM_MONT > -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DMD5_ASM -DGHASH_ASM > -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DWHIRLPOOL_ASM > -I/usr/obj/backup/freebsd/secure/lib/libcrypto > -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/a > sn1 > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/evp > = -I/backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl/crypto/mode= s > -std=3Dgnu89 -fstack-protector-strong > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int > -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conve > rsion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum > -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c > /backup/freebsd/secure/lib/libcrypto/../../../crypto/openssl > /crypto/evp/m_md5.c -o m_md5.po > --- all_subdir_sbin --- > /backup/freebsd/sbin/nvmecontrol/power.c:44:16: error: invalid = application > of 'sizeof' to an incomplete type 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:60:14: error: incomplete > definition of type 'struct nvme_power_state' > mpower =3D nps->mp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:61:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->mps =3D=3D 0) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:63:14: error: incomplete > definition of type 'struct nvme_power_state' > ipower =3D nps->idlp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:64:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->ips =3D=3D 1) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:66:14: error: incomplete > definition of type 'struct nvme_power_state' > --- all_subdir_rescue --- > --- dhclient_make --- > --- packet.o --- > --- all_subdir_sbin --- > apower =3D nps->actp; > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:67:9: error: incomplete = definition > of type 'struct nvme_power_state' > if (nps->aps =3D=3D 1) > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:35: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:71:54: error: incomplete > definition of type 'struct nvme_power_state' > nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % = 1000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:31: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:50: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:72:60: error: incomplete > definition of type 'struct nvme_power_state' > nps->exlat / 1000, nps->exlat % 1000, nps->rrt, nps->rrl, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:73:12: error: incomplete > definition of type 'struct nvme_power_state' > nps->rwt, nps->rwl, ipower / 10000, ipower % 10000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:73:22: error: incomplete > definition of type 'struct nvme_power_state' > nps->rwt, nps->rwl, ipower / 10000, ipower % 10000, > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:74:44: error: incomplete > definition of type 'struct nvme_power_state' > apower / 10000, apower % 10000, nps->apw); > ~~~^ > /backup/freebsd/sbin/nvmecontrol/power.c:44:30: note: forward = declaration > of 'struct nvme_power_state' > _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, > ^ > /backup/freebsd/sbin/nvmecontrol/power.c:86:29: error: no member named > 'power_state' in 'struct nvme_controller_data' > power_list_one(i, &cdata->power_state[i]); > ~~~~~ ^ > --- all_subdir_rescue --- > cc -O2 -pipe -DRESCUE -std=3Dgnu99 -fstack-protector-strong > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-un > used-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion > -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -W > no-knr-promoted-parameter -Qunused-arguments -c > /backup/freebsd/sbin/dhclient/packet.c -o packet.o > --- all_subdir_sbin --- > 18 errors generated. > *** [power.o] Error code 1 >=20 > make[4]: stopped in /backup/freebsd/sbin/nvmecontrol Hi, Thank you for the report. I=E2=80=99ve reverted the commit in = r295076, because it broke buildworld and the missing code wasn=E2=80=99t = apparent based on the commit done to nvmecontrol(8). Thanks! -NGie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8977554C-9BF9-4D66-AFBC-5BAEFCD58704>