Date: Mon, 8 Sep 2008 14:56:55 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-drivers@freebsd.org Cc: Rui Paulo <rpaulo@freebsd.org>, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: [Review request]: Attansic L2 ethernet driver Message-ID: <200809081456.56064.jhb@freebsd.org> In-Reply-To: <20080831222822.76d4ee92.stas@FreeBSD.org> References: <20080831222822.76d4ee92.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 31 August 2008 02:28:22 pm Stanislav Sedov wrote: > Hi! > > Seems that I've implemented the most stuff I wanted > to see in the driver for Attansic L2 ethernet controller. > I haven't received any bugreports since the last public > version and I think it's in a pretty good form and ready > to be committed in HEAD. Before that, I'd like to ask > you to review the code of the driver, since it's my > first work in this area, and I'm not sure I've done > everything correctly. > > The latest diff against HEAD is available here: > http://www.SpringDaemons.com/stas/if_ae.diff.2008083100 A few style notes: - return (FILTER_STRAY) (missing ()'s) - Extra indentation for one of the TASK_INIT()'s - Are you using 4 space indent or 8 space indent? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809081456.56064.jhb>